Closed
Bug 1376303
Opened 7 years ago
Closed 7 years ago
Expose the value of aria-orientation via NSAccessibilityOrientationAttribute
Categories
(Core :: Disability Access APIs, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: jdiggs, Assigned: jdiggs)
Details
Attachments
(1 file, 1 obsolete file)
2.47 KB,
patch
|
Details | Diff | Splinter Review |
Gecko doesn't expose the value of aria-orientation on macOS. (This support is already in place for ATK and IA2.)
Assignee | ||
Comment 1•7 years ago
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8881260 [details] [diff] [review] proposed patch Review of attachment 8881260 [details] [diff] [review]: ----------------------------------------------------------------- ::: accessible/mac/mozAccessible.h @@ +114,4 @@ > // the accessible description (help text) of this particular instance. > - (NSString*)help; > > +// returns the orientation (veritical, horizontal, or undefined) Nit: vertical (one i too many). :-)
Attachment #8881260 -
Flags: review?(mzehe) → review+
Assignee | ||
Comment 3•7 years ago
|
||
(In reply to Marco Zehe (:MarcoZ) from comment #2) > Comment on attachment 8881260 [details] [diff] [review] > proposed patch > > Review of attachment 8881260 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: accessible/mac/mozAccessible.h > @@ +114,4 @@ > > // the accessible description (help text) of this particular instance. > > - (NSString*)help; > > > > +// returns the orientation (veritical, horizontal, or undefined) > > Nit: vertical (one i too many). :-) Ugh. Sorry and thanks! :)
Attachment #8881260 -
Attachment is obsolete: true
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/47eb47a6237a Expose aria-orientation via NSAccessibilityOrientationAttribute. r=MarcoZ
Keywords: checkin-needed
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/47eb47a6237a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•