1376574 - Use posix_spawnp() on Mac to launch the crashreporter to work around bug 1376567

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, enhancement)

Description

[Gabriele Svelto [:gsvelto] (PTO)]

In bug 1322611 we simplified the code for running the crashreporter client by removing the Mac-specific path and replacing it with the fork()-based code path we use in Linux. As it turns out this is unreliable due to fork() trying to allocate memory on Mac; so we should revert to using posix_spawnp() instead.

Comment 1

[Gabriele Svelto [:gsvelto] (PTO)]

Attachment: [PATCH] WIP

Here's a WIP for this. I don't have a Mac right now so I can't test it, but I should be able to test it tomorrow.

Comment 2

[(not currently active) Ted Mielczarek]

If you can push to try with this patch I can test it locally.

Comment 3

[Gabriele Svelto [:gsvelto] (PTO)]

I've tested this locally at the all hands and it doesn't work because of the missing DYLD_LIBRARY_PATH in the environment. Feel free to pick this up while I'm on paternity leave, otherwise I'll fix it as soon as I'm back.

Comment 4

[Gabriele Svelto [:gsvelto] (PTO)]

Attachment: bug 1376574 - Do not use fork() for launching the crashreporter on Mac since that might crash too;

Review commit: https://reviewboard.mozilla.org/r/167702/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/167702/

Comment 5

[Gabriele Svelto [:gsvelto] (PTO)]

I've updated my patch and it seems to work correctly now, it was just a matter of setting DYLD_LIBRARY_PATH before launching the crashreporter client.

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 8896454 [details]
bug 1376574 - Do not use fork() for launching the crashreporter on Mac since that might crash too;

https://reviewboard.mozilla.org/r/167702/#review178688

Thanks for fixing this!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/512c998741c5
Do not use fork() for launching the crashreporter on Mac since that might crash too; r=ted

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/512c998741c5