1376860 - Give names to all non-nsINamed runnables

Status: RESOLVED WONTFIX

(Core :: XPCOM, enhancement, P3)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

This will help with the labeling effort. I think the easiest way to do this would be to make nsIRunnable inherit from nsINamed. Then every nsIRunnable would be required to have a name.

Comment 1

[Nathan Froyd [:froydnj]]

I think this is superseded by your recent work in bug 1372405?

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Bug 1372405 only covered stuff that inherits from mozilla::Runnable. We have some runnables that inherit directly from nsIRunnable. We could just fix those I guess so that they inherit from Runnable. But there are probably some legitimate use cases.

This is a probably complete list:
http://searchfox.org/mozilla-central/search?q=public%20nsIRunnable

I guess JS runnables also fall into this category. Depending on how important they are, we could probably convince xpconnect to label them automatically.

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I didn't mean to assign this to myself.

Comment 4

[Nathan Froyd [:froydnj]]

This would be desirable for moving more behavior into nsIRunnable/mozilla::Runnable.