1376893 - The temporarily disabled state of the reload button should block mouse events without flickering

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Florian Quèze [:florian]]

Currently the reload button is disabled for 650ms right after it appears to prevent accidentally reloading a page when the users tried to stop loading a page that finished loading at the exact same time.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1376893 - Don't display the disabled reload button with less opacity since it is only disabled temporarily and causes flickering in the UI.

Review commit: https://reviewboard.mozilla.org/r/152986/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/152986/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8881920 [details]
Bug 1376893 - Don't display the disabled reload button with less opacity since it is only disabled temporarily and causes flickering in the UI.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/152986/diff/1-2/

Comment 4

[Florian Quèze [:florian]]

Comment on attachment 8881920 [details]
Bug 1376893 - Don't display the disabled reload button with less opacity since it is only disabled temporarily and causes flickering in the UI.

Thanks for the patch! Looks reasonable to me, but I don't have time to review all the other existing CSS rules applying to #reload-button, so forwarding the request to Johann.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8881920 [details]
Bug 1376893 - Don't display the disabled reload button with less opacity since it is only disabled temporarily and causes flickering in the UI.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/152986/diff/2-3/

Comment 6

[Johann Hofmann [:johannh]]

Comment on attachment 8881920 [details]
Bug 1376893 - Don't display the disabled reload button with less opacity since it is only disabled temporarily and causes flickering in the UI.

https://reviewboard.mozilla.org/r/152986/#review158712

Seems good now, thanks!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a71fc08867b
Don't display the disabled reload button with less opacity since it is only disabled temporarily and causes flickering in the UI. r=johannh

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8a71fc08867b