1377008 - Teach GCPolicy about Maybe

Status: RESOLVED FIXED

(Core :: JavaScript: GC, enhancement)

Description

[David Teller [:Yoric] - still alive but not very active]

We can't really use JS::Rooted<Maybe<T>> at the moment, which is annoying.

Let's fix this.

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1377008 - Teach GCPolicy about Maybe;

Review commit: https://reviewboard.mozilla.org/r/153128/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153128/

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8882050 [details]
Bug 1377008 - Teach GCPolicy about Maybe;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/153128/diff/1-2/

Comment 3

[Jon Coppeard (:jonco)]

Comment on attachment 8882050 [details]
Bug 1377008 - Teach GCPolicy about Maybe;

https://reviewboard.mozilla.org/r/153128/#review158336

Looks good, and simpler than expected.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8aa702072b26
Teach GCPolicy about Maybe;r=jonco

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8aa702072b26