1377151 - Add drive information to main ping

Status: NEW

(Toolkit :: Telemetry, enhancement, P3)

Description

[Alex Thayer [:alexical] (she/her)]

On Linux, you should be able to just read /sys/block/sda/queue/rotational at the very least, and on Windows, see the MSFT_PhysicalDisk class [1].

[1]: https://msdn.microsoft.com/en-us/library/windows/desktop/hh830532(v=vs.85).aspx

Comment 1

[Georg Fritzsche [:gfritzsche]]

What specific drive information are you looking for?

Comment 2

[Chris H-C :chutten]

In conversation the specific drive information we're interested in is whether the drive is an SSD.

For the Windows case:

Looking in to MSFT_PhysicalDisk, we have similar plumbing in nsAppRunner[1] to pull in additional information on profiler-enabled builds.

I'm not a Windows Management Instrumentation (WMI)[2] expert, though, so I'm not sure what's needed. Looks like :dmajor was the last (only?) person to touch that code.

For the Linux case, I know even less. Though I did manage to scrape up some examples[3] of reading from /sys/block/ for memory information.

[1]: http://searchfox.org/mozilla-central/rev/152c0296f8a10f81185ee88dfb4114ec3882b4c6/toolkit/xre/nsAppRunner.cpp#3615
[2]: https://msdn.microsoft.com/en-us/library/windows/desktop/aa384642(v=vs.85).aspx
[3]: http://searchfox.org/mozilla-central/rev/a3a739de04ee6134c11546568a33dbb6a6a29907/xpcom/base/SystemMemoryReporter.cpp#751

Comment 3

[Georg Fritzsche [:gfritzsche]]

This didn't seem to come up as a need for any 57 efforts.
It might however enable certain performance analysis and breakdowns. The hardware report could also use it.

Presumably we can see which team could pick this up post 57.