1377180 - [Windows] test_subprocess_environment: PATH isn't set on the Python Wrapper

Status: RESOLVED FIXED

(Toolkit :: Async Tooling, defect)

Description

[Johan Lorenzo [:jlorenzo]]

In bug 1374589, we're enabling XPCShell tests to new taskcluster Windows VMs. [1] is failing there across both windows7 (32 bits)[2] and windows10 (64 bits)[3]. The failure is the following:

> 14:45:51     INFO -  (xpcshell/head.js) | test test_subprocess_environment pending (2)
> 14:45:51     INFO -  (xpcshell/head.js) | test run_next_test 22 finished (2)
> 14:45:51     INFO -  PID 10068 | Traceback (most recent call last):
> 14:45:51     INFO -  PID 10068 |   File "Z:\\task_1498574284\\build\\venv\\lib\\site.py", line 703, in <module>
> 14:45:51     INFO -  PID 10068 |     main()
> 14:45:51     INFO -  PID 10068 |   File "Z:\\task_1498574284\\build\\venv\\lib\\site.py", line 683, in main
> 14:45:51     INFO -  PID 10068 |     paths_in_sys = addsitepackages(paths_in_sys)
> 14:45:51     INFO -  PID 10068 |   File "Z:\\task_1498574284\\build\\venv\\lib\\site.py", line 282, in addsitepackages
> 14:45:51     INFO -  PID 10068 |     addsitedir(sitedir, known_paths)
> 14:45:51     INFO -  PID 10068 |   File "Z:\\task_1498574284\\build\\venv\\lib\\site.py", line 204, in addsitedir
> 14:45:51     INFO -  PID 10068 |     addpackage(sitedir, name, known_paths)
> 14:45:51     INFO -  PID 10068 |   File "Z:\\task_1498574284\\build\\venv\\lib\\site.py", line 173, in addpackage
> 14:45:51     INFO -  PID 10068 |     exec(line)
> 14:45:51     INFO -  PID 10068 |   File "<string>", line 1, in <module>
> 14:45:51     INFO -  PID 10068 |   File "Z:\\task_1498574284\\build\\venv\\lib\\os.py", line 425, in __getitem__
> 14:45:51     INFO -  PID 10068 |     return self.data[key.upper()]
> 14:45:51     INFO -  PID 10068 | KeyError: 'PATH'
> 14:45:51     INFO -  Unexpected exception File closed at resource://gre/modules/subprocess/subprocess_worker_win.js:80


[1] https://dxr.mozilla.org/mozilla-central/rev/9af23c413a1f8d337b19b4f8450e241e91b71136/toolkit/modules/subprocess/test/xpcshell/test_subprocess.js#661
[2] https://public-artifacts.taskcluster.net/Xjtbg0z1Qlur7tF-R0RRhA/0/public/logs/live_backing.log
[3] https://public-artifacts.taskcluster.net/XxOCHzTfTNWPSf-_pvm8lg/0/public/logs/live_backing.log

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1377180: Pass PATH environment variables with partial environment on Windows.

Review commit: https://reviewboard.mozilla.org/r/153384/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153384/

Comment 2

[Andrew Swan [:aswan]]

Comment on attachment 8882274 [details]
Bug 1377180: Pass PATH environment variables with partial environment on Windows.

https://reviewboard.mozilla.org/r/153384/#review158574

Comment 3

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b686ac9b005edffa54537eb9798ded33f3b8faae
Bug 1377180: Pass PATH environment variables with partial environment on Windows. r=aswan

Comment 4

[Johan Lorenzo [:jlorenzo]]

I tested the patch against the new environment[1] and a new error came out:

> 21:12:55  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/modules/subprocess/test/xpcshell/test_subprocess.js | test_subprocess_environmentAppend - [test_subprocess_environmentAppend : 708] Got expected $PATH value - "Z:\\\\task_1498770303\\\\build\\\\venv\\\\Scripts;C:\\\\Program Files\\\\Mercurial;C:\\\\mozilla-build\\\\7zip;C:\\\\mozilla-build\\\\info-zip;C:\\\\ == "Z:\\\\task_1498770303\\\\build\\\\venv\\\\Scripts;C:\\\\Program Files\\\\Mercurial;C:\\\\mozilla-build\\\\7zip;C:\\\\mozilla-build\\\\info-zip;C:\\\\
> 21:12:55     INFO -  Z:/task_1498770303/build/tests/xpcshell/tests/toolkit/modules/subprocess/test/xpcshell/test_subprocess.js:test_subprocess_environmentAppend:708

[1] https://public-artifacts.taskcluster.net/diNciTadRymOKwys7cXj0w/0/public/logs/live_backing.log

Comment 5

[Kris Maglione [:kmag]]

(In reply to Johan Lorenzo [:jlorenzo] from comment #4)
> I tested the patch against the new environment[1] and a new error came out:

Hm. Well that's a different test that shouldn't have been affected by these changes. It would be helpful to know the full strings that are being compared. The substrings that are reported in that failure are identical.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b686ac9b005e