1377221 - Raw talos data contains "NaN" values

Status: RESOLVED FIXED

(Testing :: Talos, enhancement)

Description

[William Lachance (:wlach)]

Because we're using the python json library to serialize the talos replicate data, the replicates can contain "NaN" which are not currently supported by all json parsers. For example:

http://mozilla-releng-blobs.s3.amazonaws.com/blobs/Firefox/sha512/f5a7a215b56f9e8d95562a73de089e1747c48d9f64ae086a91abfa11baf20c295f07833eeecb9f2006682f4c9ce8b0240d4eebc5035936093001c41645423137

The problem is this line:

http://searchfox.org/mozilla-central/rev/152c0296f8a10f81185ee88dfb4114ec3882b4c6/testing/talos/talos/output.py#199

We should be able to fix this by using the simplejson library to serialize stuff and using the ignore_nan option:

https://stackoverflow.com/questions/6601812/sending-nan-in-json

Comment 1

[William Lachance (:wlach)]

Attachment: Bug 1377221 - Use ignore_nan when dumping talos json blobs

NaN, inf, -inf values are not valid json-- let's just output null
instead when we get these values.

Review commit: https://reviewboard.mozilla.org/r/153402/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153402/

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8882307 [details]
Bug 1377221 - Use ignore_nan when dumping talos json blobs

https://reviewboard.mozilla.org/r/153402/#review158598

great find, and simple fix.

Comment 3

[William Lachance (:wlach)]

Attachment: Bug 1377221 - Add simplejson dependency to talos

Review commit: https://reviewboard.mozilla.org/r/153410/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153410/

Comment 4

[William Lachance (:wlach)]

Comment on attachment 8882307 [details]
Bug 1377221 - Use ignore_nan when dumping talos json blobs

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/153402/diff/1-2/

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8882332 [details]
Bug 1377221 - Add simplejson dependency to talos

https://reviewboard.mozilla.org/r/153410/#review158716

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e81dc885680a
Add simplejson dependency to talos r=jmaher
https://hg.mozilla.org/integration/autoland/rev/9d061aaec7aa
Use ignore_nan when dumping talos json blobs r=jmaher

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e81dc885680a
https://hg.mozilla.org/mozilla-central/rev/9d061aaec7aa