1377280 - Enable keyboard APZ on nightly

Status: RESOLVED FIXED

(Core :: Panning and Zooming, enhancement, P3)

Description

[Ryan Hunt [:rhunt] (on leave until early May)]

This bug is for enabling keyboard APZ in nightly before letting it ride the trains.

Comment 1

[Ryan Hunt [:rhunt] (on leave until early May)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0696a27e6a5a8c315fa6ff227cfcb0fc17944cea
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5d71331cfa14c07d1fded2b85465d02e29d30705

Two try runs with the pref enabled and bug 1382521 (which is on inbound), covering all tests for linux,windows, and macosx. It looks like it's green (except for win10 x64 debug which isn't run on inbound).

Comment 2

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: enable-key-apz.patch

It seems like now is a good time to land this.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8888788 [details] [diff] [review]
enable-key-apz.patch

Review of attachment 8888788 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/libpref/init/all.js
@@ +702,5 @@
>  pref("apz.fling_stop_on_tap_threshold", "0.05");
>  pref("apz.fling_stopped_threshold", "0.01");
>  pref("apz.frame_delay.enabled", false);
>  pref("apz.highlight_checkerboarded_areas", false);
> +#ifdef NIGHTLY_BUILD

We should probably exclude android from this, some people use external keyboards on android devices and I don't think the XBL bindings stuff we have will work on that platform.

Comment 4

[Ryan Hunt [:rhunt] (on leave until early May)]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #3)
> Comment on attachment 8888788 [details] [diff] [review]
> enable-key-apz.patch
> 
> Review of attachment 8888788 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: modules/libpref/init/all.js
> @@ +702,5 @@
> >  pref("apz.fling_stop_on_tap_threshold", "0.05");
> >  pref("apz.fling_stopped_threshold", "0.01");
> >  pref("apz.frame_delay.enabled", false);
> >  pref("apz.highlight_checkerboarded_areas", false);
> > +#ifdef NIGHTLY_BUILD
> 
> We should probably exclude android from this, some people use external
> keyboards on android devices and I don't think the XBL bindings stuff we
> have will work on that platform.

Yeah that sounds like a good idea. I'll update the patch.

Comment 5

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: enable-key-apz.patch

Updated to exclude Android.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8888844 [details] [diff] [review]
enable-key-apz.patch

Review of attachment 8888844 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Also when this lands please send an email to dev-platform informing people that it has been enabled.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0bbe2f5be046
Enable keyboard APZ on nightly for all platforms except Android. r=kats

Comment 9

[Ryan Hunt [:rhunt] (on leave until early May)]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #7)
> Also when this lands please send an email to dev-platform informing people
> that it has been enabled.

Will do. I'll wait a bit to make sure it'll stick.

Comment 10

[Ryan Hunt [:rhunt] (on leave until early May)]

(In reply to Ryan Hunt [:rhunt] from comment #9)
> (In reply to Kartikaya Gupta (email:[e-mail]) from comment #7)
> > Also when this lands please send an email to dev-platform informing people
> > that it has been enabled.
> 
> Will do. I'll wait a bit to make sure it'll stick.

Er, I mean stick on inbound. I'll email before it lands in central.

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0bbe2f5be046