Closed
Bug 1377339
Opened 7 years ago
Closed 1 year ago
obj_toString() called from isDate() in Angular could be faster
Categories
(Core :: JavaScript Engine, enhancement, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
WORKSFORME
Performance Impact | low |
People
(Reporter: ehsan.akhgari, Unassigned)
References
(Blocks 1 open bug)
Details
(Keywords: perf)
Profile: http://bit.ly/2tq8t6r from Jan: ehsan: isDate is just -- return toString.call(value) === '[object Date]' -- I wonder if we could optimize that better in Ion, will think about it
Comment 1•7 years ago
|
||
I'll check what kind of type information we have for |value|... When there's a single Class we could use TI to optimize (just need to be careful with @@toStringTag..). Worst case we could call a VM function and avoid some of the type checks at the start of obj_toString.
Flags: needinfo?(jdemooij)
Comment hidden (obsolete) |
Reporter | ||
Comment 3•7 years ago
|
||
(In reply to :Ehsan Akhgari (needinfo please, extremely long backlog) from comment #2) > I don't see this in profiles any more: https://perfht.ml/2i74Rlx > > Could it be that something changed to fix it? Can we close the bug? No, I'm just incompetent at using the profiler UI: https://perfht.ml/2fLDbBL Sorry for the noise...
Comment 4•7 years ago
|
||
(In reply to :Ehsan Akhgari (needinfo please, extremely long backlog) from comment #3) > No, I'm just incompetent at using the profiler UI: https://perfht.ml/2fLDbBL > Sorry for the noise... Note that this profile is for Ember, not Angular, and the Ember case is bug 1384562. I should probably get back to that :)
Flags: needinfo?(jdemooij)
Updated•7 years ago
|
status-firefox57:
--- → wontfix
status-firefox58:
--- → fix-optional
Keywords: perf
Priority: -- → P3
Whiteboard: [qf:p3]
Comment 5•6 years ago
|
||
https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Move_fix-optionals
status-firefox59:
--- → ?
Updated•2 years ago
|
Performance Impact: --- → P3
Whiteboard: [qf:p3]
Updated•2 years ago
|
Severity: normal → S3
Comment 6•1 year ago
|
||
I'm not seeing this behaviour any more.
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → INVALID
Updated•1 year ago
|
Resolution: INVALID → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•