Closed
Bug 1377486
Opened 7 years ago
Closed 7 years ago
Make nsWindow final to allow the compiler to devirtualize some calls
Categories
(Core :: Widget: Gtk, enhancement)
Core
Widget: Gtk
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
References
(Blocks 1 open bug)
Details
(Keywords: perf)
Attachments
(2 files)
|
3.80 KB,
patch
|
tnikkel
:
review+
|
Details | Diff | Splinter Review |
|
1.07 KB,
patch
|
tnikkel
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•7 years ago
|
||
The nsChildWindow child class is empty so it can be removed and thus we can make nsWindow 'final'. Green on Linux. I'm also working on the same for Windows, but that doesn't quite work yet... https://treeherder.mozilla.org/#/jobs?repo=try&revision=ed958cccbc7f110e2fbb49c79f2b09d7b8d4b20d
Attachment #8882601 -
Flags: review?(tnikkel)
|
||
Updated•7 years ago
|
Attachment #8882601 -
Flags: review?(tnikkel) → review+
|
|
Assignee | |
Comment 2•7 years ago
|
||
Actually, I might as well tag along Android / UIKit here since they were so trivial (assuming they compile): https://treeherder.mozilla.org/#/jobs?repo=try&revision=98a2b76d0a30bd7aad52fecc1fd7afc7470ed975
|
|
Assignee | |
Comment 3•7 years ago
|
||
(I'm fixing Windows in bug 1377490 and cocoa in bug 1377591)
|
|
Assignee | |
Comment 4•7 years ago
|
||
I'll fold this into the first part before landing.
Attachment #8882726 -
Flags: review?(tnikkel)
|
|
||
Updated•7 years ago
|
Attachment #8882726 -
Flags: review?(tnikkel) → review+
Pushed by mpalmgren@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b3a2348ce59f Make nsWindow 'final' to possibly devirtualize some calls. r=tn
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b3a2348ce59f
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
|
||
Updated•2 years ago
|
Performance Impact: --- → ?
Whiteboard: [qf]
You need to log in
before you can comment on or make changes to this bug.
Description
•