1377790 - Firefox sends "tickle-wifi" UDP packets to 1.0.0.0 instead of default gateway

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mira Weller]

Attachment: Screenshot_20170702_223554.png

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.109 Safari/537.36

Steps to reproduce:

* Run tcpdump on my router to see packets sent to the internet (optionally limited to UDP packets on port 4886)

* Open any website in Firefox for Android (while connected via aforementioned router)



Actual results:

Lots of UDP packets are sent to 1.0.0.0:4886 (see screenshot), an address from the APNIC research prefix.




Expected results:

According to bug #888268, these packets should be sent to the default gateway, never leaving the LAN.

I suppose the underlying problem is as follows:
The default gateway's IP address is retrieved from dom/network/Connection.cpp, which casts the IP address from uint32_t to bool and back to uint32_t, therefore it has the value "1", which corresponds to the IP address 1.0.0.0.

Comment 1

[Mira Weller]

Attachment: fixDhcpGateway.patch

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

Comment on attachment 8882926 [details] [diff] [review]
fixDhcpGateway.patch

Snorp please have a look at this patch or send it to a reviewer that can review it.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8882926 [details] [diff] [review]
fixDhcpGateway.patch

Review of attachment 8882926 [details] [diff] [review]:
-----------------------------------------------------------------

Wow! Nice catch!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/207dd6b9d716
Fix setting of default gateway's IP address. r=snorp

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/207dd6b9d716