1378015 - Rewrite aom/test_general.html so that it doesn't rely on hashtable enumeration order

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[(no longer active)]

It seems like my patch in bug 1377947 is changing the hashtable enumeration order of nsPersistentProperties::mTable in the object that AccessibleNode::mIntl->Attributes() returns.

The buggy test is accessible/tests/mochitest/aom/test_general.html, see this code where ordering assumption is built in: <https://searchfox.org/mozilla-central/rev/a3a739de04ee6134c11546568a33dbb6a6a29907/accessible/tests/mochitest/aom/test_general.html#91>

Here is the respective hashtable enumeration: <https://searchfox.org/mozilla-central/rev/a3a739de04ee6134c11546568a33dbb6a6a29907/xpcom/ds/nsPersistentProperties.cpp#546>

This is probably an existing intermittent failure.

Comment 1

[(no longer active)]

Forgot to mention that Enumerate is called from here: https://searchfox.org/mozilla-central/rev/a3a739de04ee6134c11546568a33dbb6a6a29907/accessible/aom/AccessibleNode.cpp#91)

Comment 2

[(no longer active)]

Attachment: Rewrite aom/test_general.html so that it doesn't rely on hashtable enumeration order

Comment 3

[(no longer active)]

Wrong bug!

Comment 4

[Marco Zehe (:MarcoZ)]

Comment on attachment 8883151 [details] [diff] [review]
Rewrite aom/test_general.html so that it doesn't rely on hashtable enumeration order

Stealing r from surkov, since he won't be back until next week. Thanks, Ehsan!

Comment 5

[(no longer active)]

Thanks for the review!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/738ae725fe19
Rewrite aom/test_general.html so that it doesn't rely on hashtable enumeration order; r=MarcoZ

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/738ae725fe19