1378111 - Minimize/maximize/close buttons are not visible with Light Themes/Appearances/Personas

Status: VERIFIED FIXED

(Core :: Graphics: Layers, defect)

Description

[Vlad Bacia-Mociran [:VladB]]

Attachment: missing window buttons when the browser is maximized using compact themes

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20170703030203

[Affected versions]:
- Firefox nightly 56.0a1

[Affected Platforms]:
- Windows 8.1

[Prerequisites]:
- Firefox Nightly browser is maximized.

[Steps to reproduce]:
1. Click on "Hamburger Menu" button.
2. Click on "Customize..." button.
3. From Themes select Compact Dark or Compact Light.
4. Click on "Done" button.

[Expected result]:
- Theme is successfully changed and browser window buttons are displayed.

[Actual result]:
- After the theme is changed with one from the compact ones, the browser window buttons are no longer displayed. If the user clicks on an area where the buttons should be, the action is made for the button that supposed to be displayed in that area.

[Notes]:
- Attached a screenshot of the issue.

Comment 1

[Vlad Bacia-Mociran [:VladB]]

I did a regression range and this is the log:

INFO: Narrowed inbound regression window from [3dac0535, bc2343d4] (3 revisions) to [3dac0535, 684b6b32] (2 revisions) (~1 steps left)
INFO: No more inbound revisions, bisection finished.
INFO: Last good revision: 3dac05357e713c8f15a5e2561e2ed22a10c7ebc8
INFO: First bad revision: 684b6b32fab2c5a88f4b2ae397a36a007bd8cb39
INFO: Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=3dac05357e713c8f15a5e2561e2ed22a10c7ebc8&tochange=684b6b32fab2c5a88f4b2ae397a36a007bd8cb39

It seems that Bug 1375743 has caused this. @David, can you take a look at this?

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

I can't reproduce this - can you attach your about:support?

Comment 3

[Vlad Bacia-Mociran [:VladB]]

Apparently this issue is no longer reproducible with latest Nightly (Build ID: 20170704030203).

Comment 5

[Dão Gottwald [:dao]]

(In reply to Vlad Bacia-Mociran [:VladB], Desktop Engineering QA from comment #3)
> Apparently this issue is no longer reproducible with latest Nightly (Build
> ID: 20170704030203).

Well, bug 1375743 got backed out.

Comment 6

[David Anderson [:dvander] - inactive, e-mail if emergency]

You can re-test by setting layers.mlgpu.dev-enabled = true. We're going to re-enable bug 1375743 soon though, so please re-open if it still happens after.

Comment 8

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I can reproduce this issue on Windows 7.

Comment 9

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

minimize/maximize/close buttons with Default theme are hazy
minimize/maximize/close buttons with other Light/Appearance/Persona theme are not visible

Comment 10

[David Anderson [:dvander] - inactive, e-mail if emergency]

(In reply to Virtual_ManPL [:Virtual] - (please needinfo? me - so I will see your comment/reply/question/etc.) from comment #8)
> I can reproduce this issue on Windows 7.

Advanced Layers isn't enabled on Windows 7 - did you force it on via about:config?

Comment 11

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: Graphics section from about:support.txt

Yes.
I enabled it by myself by setting to "true" these 2 preferences: "layers.mlgpu.dev-enabled" & "layers.mlgpu.enable-on-windows7", it was to see if it's fixed yet, per re-enabling Advanced Layers in Nightly on Windows 8+ and to see if it's also reproducible on Windows 7.

I'm attaching Graphics section from about:support.

Comment 12

[David Anderson [:dvander] - inactive, e-mail if emergency]

Does this reproduce on Windows 10 or only 7 and 8.1?

Comment 13

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I can reproduce it on Windows 7,
but looking on dupe and on OP post, it is or was reproducible also on Windows 8.1.

Comment 14

[John]

It is reproducible on Windows 8.1 for me at the moment.

Comment 15

[David Anderson [:dvander] - inactive, e-mail if emergency]

I'm unable to reproduce this on like four different computers. Could anyone take a full window screenshot or video of what happens?

Comment 16

[John]

Attachment: 1378111.png

Comment 17

[David Anderson [:dvander] - inactive, e-mail if emergency]

Thanks, that is more clear - I was able to reproduce this on Windows 8.1. It seems to be fixed by bug 1378095, but I'll leave this open so folks can confirm after that lands.

Comment 19

[John]

It has been fixed for me on latest Nightly 20170713030205 (Windows 8.1).

Comment 20

[Vlad Bacia-Mociran [:VladB]]

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20170713030205

I can reproduce this issue on Windows 8.1.

Comment 21

[John]

I'm sorry for my mistake. 
For some reason layers.mlgpu.sanity-test-failed set to 'true' (but before 20170713030205 this has been 'false').

Comment 22

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

It's fixed starting with Mozilla Firefox Nightly 56.0a1 (2017-07-14).

Comment 23

[Md. Rahimul Islam]

I have successfully reproduced this bug with Nightly 56.0a1 (2017-07-04) (32-bit) on windows 10(32bit)

this bug is verified fix with  latest beta 58.0b4 (32-bit)
Build ID: 20171115114231
Mozilla/5.0 (Windows NT 10.0; rv:58.0) Gecko/20100101 Firefox/58.0

Comment 24

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

I also can confirm that the issue is verified fixed on 56.0.2 build1 (20171024165158) (and that 57.0 and 58.0b4 builds are not affected) using Windows 8.1 x64. 
Thank you Md. Rahimul Islam for your testing efforts!