Closed Bug 1378160 Opened 7 years ago Closed 7 years ago

The ARIA region role should be exposed as a landmark; not a pane

Categories

(Core :: Disability Access APIs, defect)

Product:
Core
Component:
Disability Access APIs
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: jdiggs, Assigned: jdiggs)

References

Details

Attachments

(1 file, 1 obsolete file)

proposed patch
5.60 KB, patch
MarcoZ
: review+
Details | Diff | Splinter Review 
In ARIA 1.1, region became a landmark*. As such it is expected to be exposed as a landmark. But currently region maps to Gecko's panel role, which in turn maps to the generic group/container role in platform accessibility APIs.

*Note that as a landmark, it is expected to have an author-provided name. If it lacks an author-provided name, then the mapping should be based on the native host language according to the Core AAM. Addressing that scenario is bug 1358462.
Attached patch patch (obsolete) — — Splinter Review 
Assignee: nobody → jdiggs
Status: NEW → ASSIGNED

        Attachment #8883326 -
        Flags: review?(mzehe)

    
  
Blocks: 1358462

    
    

    
  
Comment on attachment 8883326 [details] [diff] [review]
patch

Clearing the r? flag for now. While this simple patch fixes this simple bug, we still need to deal with bug 1358462, and fixing that bug may be easier if we have a dedicated internal REGION role immediately distinguishable from the internal LANDMARK role. In which case, might as well make the REGION role here....

        Attachment #8883326 -
        Attachment description: proposed patch → patch

        Attachment #8883326 -
        Flags: review?(mzehe)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        proposed patch
        — 
          — Splinter Review
      

    


  

        Attachment #8883326 -
        Attachment is obsolete: true

        Attachment #8883429 -
        Flags: review?(mzehe)

        Attachment #8883429 -
        Flags: review?(mzehe) → review+

    
  
Keywords: checkin-needed

    
    

    
  
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9bf712264165
The ARIA region role should be exposed as a landmark; not a pane. r=MarcoZ
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/9bf712264165
Status: ASSIGNED → RESOLVED
Closed: 7 years ago

          status-firefox56:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: