Closed
Bug 1378218
Opened 7 years ago
Closed 7 years ago
Don't register visited callback if we have pending link update
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: smaug, Assigned: smaug)
References
Details
Attachments
(3 files)
|
1.83 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
|
2.56 KB,
patch
|
Details | Diff | Splinter Review | |
|
2.60 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
Don't know what tryserver thinks of this remote: View your change here: remote: https://hg.mozilla.org/try/rev/939a561f5fd658c5ceffb52e25c4536f96a889ba remote: remote: Follow the progress of your build on Treeherder: remote: https://treeherder.mozilla.org/#/jobs?repo=try&revision=939a561f5fd658c5ceffb52e25c4536f96a889ba
Attachment #8883390 -
Flags: review?(ehsan)
|
||
Updated•7 years ago
|
Attachment #8883390 -
Flags: review?(ehsan) → review+
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8eb0c588a43e Don't register visited callback if we have pending link update, r=ehsan
I had to back this out for being the apparent cause of frequent failures in test_sanitizer.js https://treeherder.mozilla.org/logviewer.html#?job_id=112061477&repo=mozilla-inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/b7373e1df03eac30bca7b882a352a7282775059e
Flags: needinfo?(bugs)
|
Assignee | |
Comment 3•7 years ago
|
||
sanitizer... huh
Backout by kwierso@gmail.com: https://hg.mozilla.org/mozilla-central/rev/af0466865a21 Backed out changeset 8eb0c588a43e for frequent win debug xpcshell failures in test_sanitizer.js a=backout
|
|
Assignee | |
Comment 5•7 years ago
|
||
Aha, mozStorageService.cpp seems to have a bug.
|
|
Assignee | |
Comment 6•7 years ago
|
||
yeah, it totally has bogus assumption.
|
|
Assignee | |
Comment 7•7 years ago
|
||
Flags: needinfo?(bugs)
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/47021e6deb24 Don't register visited callback if we have pending link update, r=ehsan
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/35bdc75bcca9 back out the wrong patch, r=me
|
|
Assignee | |
Comment 10•7 years ago
|
||
oops, sorry, I shouldn't have landed that patch. backed it out.
|
|
Assignee | |
Comment 11•7 years ago
|
||
remote: Follow the progress of your build on Treeherder: remote: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9ae2e674002d074b2d84fb1607a6cc7d7994b4f4
|
|
Assignee | |
Comment 12•7 years ago
|
||
The issue in mozStorageService is that it assumes the service can't be instantiated after xpcom-shutdown. And since the patch in this bug makes us rely more on idle dispatch, we sure may do stuff later.
|
||
Updated•7 years ago
|
Attachment #8884044 -
Flags: review+
|
||
Comment 13•7 years ago
|
||
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3b8cf0ecd184 Don't register visited callback if we have pending link update, r=ehsan,baku
|
||
Comment 14•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3b8cf0ecd184
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•