1378300 - stylo: Crash in nsBindingManager::AppendAllSheets

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[[:philipp]]

This bug was filed from the Socorro interface and is 
report bp-41c7ec98-b32d-4425-afa0-f19d20170704.
=============================================================
Crashing Thread (0)
Frame 	Module 	Signature 	Source
0 	libxul.so 	nsBindingManager::AppendAllSheets 	xpcom/base/nsAutoPtr.h:171
1 	libxul.so 	inDOMUtils::GetAllStyleSheets 	layout/inspector/inDOMUtils.cpp:102
2 	libxul.so 	NS_InvokeByIndex 	
3 	libxul.so 	XPCWrappedNative::CallMethod(XPCCallContext&, XPCWrappedNative::CallMode) 	
4 	libxul.so 	XPC_WN_CallMethod(JSContext*, unsigned int, JS::Value*) 	
5 	libxul.so 	js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct) 	
6 	libxul.so 	Interpret(JSContext*, js::RunState&) 	
7 	libxul.so 	js::RunScript(JSContext*, js::RunState&) 	
8 	libxul.so 	js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>) 	
9 	libxul.so 	JS_CallFunctionValue(JSContext*, JS::Handle<JSObject*>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>) 	
10 	libxul.so 	nsXPCWrappedJSClass::CallMethod(nsXPCWrappedJS*, unsigned short, XPTMethodDescriptor const*, nsXPTCMiniVariant*) 	
11 	libxul.so 	PrepareAndDispatch 	xpcom/reflect/xptcall/md/unix/xptcstubs_x86_64_linux.cpp:120
12 	libxul.so 	SharedStub 	
13 	libxul.so 	nsObserverList::NotifyObservers(nsISupports*, char const*, char16_t const*) 	
14 	libxul.so 	nsObserverService::NotifyObservers(nsISupports*, char const*, char16_t const*) 	
15 	libxul.so 	nsGlobalWindow::DispatchDOMWindowCreated 	dom/base/nsGlobalWindow.cpp:3451
16 	libxul.so 	mozilla::detail::RunnableMethodImpl<nsGlobalWindow*, void (nsGlobalWindow::*)(), true, (mozilla::RunnableKind)0u>::Run 	xpcom/threads/nsThreadUtils.h:1138
17 	libxul.so 	nsContentUtils::RemoveScriptBlocker() 	
18 	libxul.so 	nsDocumentViewer::InitInternal(nsIWidget*, nsISupports*, mozilla::gfx::IntRectTyped<mozilla::gfx::UnknownUnits> const&, bool, bool, bool) 	
19 	libxul.so 	nsDocumentViewer::Init 	layout/base/nsDocumentViewer.cpp:711
20 	libxul.so 	nsDocShell::SetupNewViewer(nsIContentViewer*) 	
21 	libxul.so 	nsDocShell::Embed(nsIContentViewer*, char const*, nsISupports*) 	
22 	libxul.so 	nsDocShell::CreateContentViewer(nsACString const&, nsIRequest*, nsIStreamListener**) 	
23 	libxul.so 	nsDSURIContentListener::DoContent(nsACString const&, bool, nsIRequest*, nsIStreamListener**, bool*) 	
24 	libxul.so 	nsDocumentOpenInfo::TryContentListener(nsIURIContentListener*, nsIChannel*) 	
25 	libxul.so 	nsDocumentOpenInfo::DispatchContent(nsIRequest*, nsISupports*) 	
26 	libxul.so 	nsDocumentOpenInfo::OnStartRequest(nsIRequest*, nsISupports*) 	
27 	libxul.so 	mozilla::net::HttpChannelChild::DoOnStartRequest 	netwerk/protocol/http/HttpChannelChild.cpp:662
28 	libxul.so 	mozilla::net::HttpChannelChild::OnStartRequest 	netwerk/protocol/http/HttpChannelChild.cpp:593
29 	libxul.so 	mozilla::net::StartRequestEvent::Run 	netwerk/protocol/http/HttpChannelChild.cpp:430
30 	libxul.so 	mozilla::net::ChannelEventQueue::RunOrEnqueue 	netwerk/ipc/ChannelEventQueue.h:215
31 	libxul.so 	mozilla::net::HttpChannelChild::RecvOnStartRequest 	netwerk/protocol/http/HttpChannelChild.cpp:489
32 	libxul.so 	mozilla::net::PHttpChannelChild::OnMessageReceived 	obj-firefox/ipc/ipdl/PHttpChannelChild.cpp:637
33 	libxul.so 	mozilla::dom::PContentChild::OnMessageReceived 	obj-firefox/ipc/ipdl/PContentChild.cpp:5288
34 	libxul.so 	mozilla::ipc::MessageChannel::DispatchAsyncMessage(IPC::Message const&) 	
35 	libxul.so 	libxul.so@0xc7c361 	
36 	libxul.so 	mozilla::ipc::MessageChannel::MessageTask::Run() 	
37 	libxul.so 	mozilla::SchedulerGroup::Runnable::Run 	xpcom/threads/SchedulerGroup.cpp:367
38 	libxul.so 	nsThread::ProcessNextEvent(bool, bool*) 	
39 	libxul.so 	NS_ProcessNextEvent(nsIThread*, bool) 	
40 	libxul.so 	mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) 	
41 	libxul.so 	MessageLoop::Run() 	
42 	libxul.so 	nsBaseAppShell::Run 	widget/nsBaseAppShell.cpp:156
43 	libxul.so 	XRE_RunAppShell 	toolkit/xre/nsEmbedFunctions.cpp:895
44 	libxul.so 	MessageLoop::Run() 	
45 	libxul.so 	XRE_InitChildProcess 	toolkit/xre/nsEmbedFunctions.cpp:711
46 	firefox 	content_process_main 	ipc/contentproc/plugin-container.cpp:64
47 	firefox 	_init 	
Ø 48 	libc-2.23.so 	libc-2.23.so@0x2082f 	
49 	firefox 	firefox@0x118af 	
50 	firefox 	firefox@0x1b14f 	
51 	firefox 	firefox@0x118af 	
52 	firefox 	mozilla::ReadAheadLib(char const*) 	
53 	firefox 	firefox@0x1b14f 	
54 	firefox 	_start

this crash signature is newly showing up since 56.0a1 build 20170703100343 and may be related to bug 1377196.

Comment 1

[Cameron McCormack (:heycam)]

This crash is with stylo enabled.

I think we just need to remove the AsGecko() call now that AppendAllXBLStyleSheets() is implemented for both style set types in bug 1377196.

Comment 2

[Cameron McCormack (:heycam)]

Attachment: Bug 1378300 - Stop assuming Gecko style set when fetching XBL sheets for devtools.

Review commit: https://reviewboard.mozilla.org/r/154432/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/154432/

Comment 3

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d2547c6f71114a082aea8ddf721d48913c0c0083

Comment 5

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 8883513 [details]
Bug 1378300 - Stop assuming Gecko style set when fetching XBL sheets for devtools.

https://reviewboard.mozilla.org/r/154432/#review159736

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0da28256801b
Stop assuming Gecko style set when fetching XBL sheets for devtools. r=xidorn

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0da28256801b