1378454 - Add predictable routes to repackage and repackage-signing tasks

Status: RESOLVED FIXED

(Release Engineering :: General, enhancement)

Description

[Rail Aliiev [:rail]]

So we can find them as part of release promotion.

Comment 1

[Rail Aliiev [:rail]]

Attachment: routes.diff

Not sure if this is the best approach. I don't really like the fact that I have copy-paste functions in 2 files :/

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 8884041 [details] [diff] [review]
routes.diff

Review of attachment 8884041 [details] [diff] [review]:
-----------------------------------------------------------------

Kind of ugly, but I won't nitpick too much in our efforts to get these routes added. Mostly because I don't have a good alternate solution in mind atm.

::: taskcluster/taskgraph/transforms/task.py
@@ +98,5 @@
>          'job-name': basestring,
>  
>          # Type of gecko v2 index to use
> +        'type': Any('generic', 'nightly', 'l10n', 'nightly-with-multi-l10n',
> +                    'repackage', 'repackage-signing'),

no repackage-signing below, and not used elsewhere.

Comment 3

[Rail Aliiev [:rail]]

Attachment: Bug 1378454 - Add predictable routes to repackage and repackage-signing tasks

Review commit: https://reviewboard.mozilla.org/r/155270/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/155270/

Comment 4

[Rail Aliiev [:rail]]

Comment on attachment 8884346 [details]
Bug 1378454 - Add predictable routes to repackage and repackage-signing tasks

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/155270/diff/1-2/

Comment 5

[Justin Wood (:Callek)]

Comment on attachment 8884346 [details]
Bug 1378454 - Add predictable routes to repackage and repackage-signing tasks

https://reviewboard.mozilla.org/r/155270/#review160350

Some minor commentary here.

::: taskcluster/docs/attributes.rst:167
(Diff revision 2)
>  Signals that the output of this task contains signed artifacts.
> +
> +repackage_type
> +==============
> +This is the type of repackage. Can be ``repackage`` or 
> +``repacakge_signing``.

can we just use 'signed' here? (or does `repackage` emit signed?)

::: taskcluster/taskgraph/transforms/repackage_routes.py:23
(Diff revision 2)
> +def validate(config, jobs):
> +    for job in jobs:
> +        label = job['label']
> +        yield validate_schema(
> +            job_description_schema, job,
> +            "In repackage-signing ({!r} kind) task for {!r}:".format(config.kind, label))

repackage passes to `job` but repackage_signing passes directly to `task`, so I'm not sure the latter would validate as a job.

Comment 6

[Rail Aliiev [:rail]]

(In reply to Justin Wood (:Callek) from comment #5)
> > +repackage_type
> > +==============
> > +This is the type of repackage. Can be ``repackage`` or 
> > +``repacakge_signing``.
> 
> can we just use 'signed' here? (or does `repackage` emit signed?)

It depends. Some pieces are signed (dmg) and some are not (setup.exe). This is why I didn't reuse the "signed" attribute.

 
> ::: taskcluster/taskgraph/transforms/repackage_routes.py:23
> (Diff revision 2)
> > +def validate(config, jobs):
> > +    for job in jobs:
> > +        label = job['label']
> > +        yield validate_schema(
> > +            job_description_schema, job,
> > +            "In repackage-signing ({!r} kind) task for {!r}:".format(config.kind, label))
> 
> repackage passes to `job` but repackage_signing passes directly to `task`,
> so I'm not sure the latter would validate as a job.

I think they both yield `job` at the end, even though they are called `task`. It works somehow. :)

Comment 7

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 5d540400c15c -d 407df61a6300: rebasing 405856:5d540400c15c "Bug 1378454 - Add predictable routes to repackage and repackage-signing tasks r=Callek" (tip)
merging taskcluster/ci/repackage-signing/kind.yml
merging taskcluster/ci/repackage/kind.yml
merging taskcluster/docs/attributes.rst
merging taskcluster/taskgraph/transforms/gecko_v2_whitelist.py
merging taskcluster/taskgraph/transforms/repackage.py
merging taskcluster/taskgraph/transforms/repackage_signing.py
merging taskcluster/taskgraph/transforms/task.py
warning: conflicts while merging taskcluster/taskgraph/transforms/repackage.py! (edit, then use 'hg resolve --mark')
warning: conflicts while merging taskcluster/taskgraph/transforms/repackage_signing.py! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/441e4152c4b3
Add predictable routes to repackage and repackage-signing tasks r=Callek

Comment 9

[Rail Aliiev [:rail]]

Comment on attachment 8884346 [details]
Bug 1378454 - Add predictable routes to repackage and repackage-signing tasks

https://hg.mozilla.org/integration/mozilla-inbound/rev/441e4152c4b30c7b066edeeacbddf85852ad22ad

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/integration/autoland/rev/441e4152c4b3

Comment 11

[Ekanan Ketunuti]

https://hg.mozilla.org/mozilla-central/rev/441e4152c4b3