1378607 - Return unknown codec instead of error

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Alfredo Yang (:alfredo)]

In mp4 rust parser, it uses to return an error when parsing unknown box in audio_sample_entry and video_sample_entry. We should reutrn CodecType::Unknown and SampleEntry::Unknown.
So we can get rid of bugs like bug 1372838 and bug 1374194.

Comment 1

[Alfredo Yang (:alfredo)]

https://github.com/mozilla/mp4parse-rust/pull/101

Comment 2

[Alfredo Yang (:alfredo)]

Attachment: Bug 1378607 - skip unknown codec type.

Review commit: https://reviewboard.mozilla.org/r/154766/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/154766/

Comment 3

[Matthew Gregan [:kinetik]]

Comment on attachment 8883811 [details]
Bug 1378607 - skip unknown codec type.

https://reviewboard.mozilla.org/r/154766/#review160088

Does it make sense to circle back and remove AC3/EAC3/JPEG and any others we added before taking this approach?

Comment 4

[Alfredo Yang (:alfredo)]

(In reply to Matthew Gregan [:kinetik] from comment #3)
> Comment on attachment 8883811 [details]
> Bug 1378607 - skip unknown codec type.
> 
> https://reviewboard.mozilla.org/r/154766/#review160088
> 
> Does it make sense to circle back and remove AC3/EAC3/JPEG and any others we
> added before taking this approach?

Yes, I'm thinking to remove the codes in mp4parse_cap, so it returns unknown codecs for ac3/ec3/jpeg in mp4parse_get_track_info(). I'll file another bug for this.

Comment 5

[Alfredo Yang (:alfredo)]

Attachment: Bug 1378607 - update rust mp4 parser.

Review commit: https://reviewboard.mozilla.org/r/155066/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/155066/

Comment 6

[Matthew Gregan [:kinetik]]

Comment on attachment 8884144 [details]
Bug 1378607 - update rust mp4 parser.

https://reviewboard.mozilla.org/r/155066/#review160124

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22cec1837059
skip unknown codec type. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/bed1180449df
update rust mp4 parser. r=kinetik

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/22cec1837059
https://hg.mozilla.org/mozilla-central/rev/bed1180449df