1378740 - Consider sharing RegExpShared across compartments

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Jan de Mooij [:jandem]]

It's now a per-compartment table but it seems we could make it per-Zone. Then compartments within a zone can share RegExpShareds and regexp JIT code.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Patch

This patch splits RegExpCompartment into RegExpZone (containing the RegExpShared table) and RegExpCompartment (just some template objects).

Still waiting for Try results but things work fine in the shell.

Comment 2

[Jon Coppeard (:jonco)]

Comment on attachment 8883930 [details] [diff] [review]
Patch

Review of attachment 8883930 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, r=me assuming try is green.

::: js/src/vm/RegExpShared.h
@@ +266,5 @@
> +    }
> +
> +    bool init();
> +
> +    bool empty() { return set_.empty(); }

nit: could make this const.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a47b92874b2b
Share RegExpShareds across compartments within a zone. r=jonco

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a47b92874b2b