Open Bug 1378892 Opened 7 years ago Updated 2 years ago

NVImage appears broken

Categories

(Core :: Graphics, defect, P3)

Product:
Core
Component:
Graphics
Type:
defect

Tracking

()

Tracking Flags:
Tracking Status
firefox57 --- fix-optional

People

(Reporter: jya, Unassigned)

References

Details

(Whiteboard: [gfx-noted]) 

In bug 1141979, a NVImage type was added.

However, this image type incorrectly assume that the different plane strides are equal to the width.

This is rarely the case, especially with odd width image:

When calculating the size:
https://dxr.mozilla.org/mozilla-central/source/gfx/layers/ImageContainer.cpp#666

when creating the image:
https://dxr.mozilla.org/mozilla-central/source/gfx/layers/ImageContainer.cpp#671

Additionally, this code will leak should any dimensions be invalid, or any error conditions be triggered during the call to GetAsSourceSurface()

https://dxr.mozilla.org/mozilla-central/source/gfx/layers/ImageContainer.cpp#668
Whiteboard: [gfx-noted]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Assignee: kakukogou → nobody
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.