1379173 - tab strip background color changes when browser window is unfocused on win10 even when accent color title bars are disabled

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Screenshot 2017-07-07 10.32.43.png

With the latest nightly I am seeing any browser window that is not focused get a different tab strip background color.  The constant color switching is kind of disconcerting.

See attached screenshot.

About:support info:

Application Basics
------------------

Name: Firefox
Version: 56.0a1
Build ID: 20170707030206
Update Channel: nightly
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
OS: Windows_NT 10.0
Multiprocess Windows: 4/4 (Enabled by default)
Stylo: false (disabled by default)
Google Key: Found
Mozilla Location Service Key: Found
Safe Mode: false

Crash Reports for the Last 3 Days
---------------------------------

Report ID: bp-b17320f4-2b73-46bd-82fe-11a3f0170706
Submitted: 21 hours ago

Report ID: bp-b8cb10d8-17d7-4467-8142-dba7b0170706
Submitted: 23 hours ago

All Crash Reports

Nightly Features
----------------

Name: Activity Stream
Version: 0.0.0
ID: [e-mail]

Name: Application Update Service Helper
Version: 2.0
ID: [e-mail]

Name: Click-to-Play staged rollout
Version: 1.2
ID: [e-mail]

Name: Firefox Screenshots
Version: 10.3.0
ID: [e-mail]

Name: FlyWeb
Version: 1.0.0
ID: [e-mail]

Name: Follow-on Search Telemetry
Version: 0.9.1
ID: [e-mail]

Name: Form Autofill
Version: 1.0
ID: [e-mail]

Name: Multi-process staged rollout
Version: 1.70
ID: [e-mail]

Name: Photon onboarding
Version: 0.1
ID: [e-mail]

Name: Pocket
Version: 1.0.5
ID: [e-mail]

Name: Presentation
Version: 1.0.0
ID: [e-mail]

Name: Shield Recipe Client
Version: 55
ID: [e-mail]

Name: Web Compat
Version: 1.1
ID: [e-mail]

Name: WebCompat Reporter
Version: 1.0.0
ID: [e-mail]

Extensions
----------

Name: Mozilla Tree Status
Version: 1.0.2
Enabled: false
ID: [e-mail]

Graphics
--------

Features
Compositing: Direct3D 11
Asynchronous Pan/Zoom: wheel input enabled; scrollbar drag enabled
WebGL 1 Driver WSI Info: EGL_VENDOR: Google Inc. (adapter LUID: 0000000000010a60) EGL_VERSION: 1.4 (ANGLE 2.1.0.dec065540d5f) EGL_EXTENSIONS: EGL_EXT_create_context_robustness EGL_ANGLE_d3d_share_handle_client_buffer EGL_ANGLE_d3d_texture_client_buffer EGL_ANGLE_surface_d3d_texture_2d_share_handle EGL_ANGLE_query_surface_pointer EGL_ANGLE_window_fixed_size EGL_ANGLE_keyed_mutex EGL_ANGLE_surface_orientation EGL_ANGLE_direct_composition EGL_NV_post_sub_buffer EGL_KHR_create_context EGL_EXT_device_query EGL_KHR_image EGL_KHR_image_base EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_get_all_proc_addresses EGL_KHR_stream EGL_KHR_stream_consumer_gltexture EGL_NV_stream_consumer_gltexture_yuv EGL_ANGLE_flexible_surface_compatibility EGL_ANGLE_stream_producer_d3d_texture_nv12 EGL_ANGLE_create_context_webgl_compatibility EGL_CHROMIUM_create_context_bind_generates_resource EGL_EXTENSIONS(nullptr): EGL_EXT_client_extensions EGL_EXT_platform_base EGL_EXT_platform_device EGL_ANGLE_platform_angle EGL_ANGLE_platform_angle_d3d EGL_ANGLE_device_creation EGL_ANGLE_device_creation_d3d11 EGL_ANGLE_experimental_present_path EGL_KHR_client_get_all_proc_addresses
WebGL 1 Driver Renderer: Google Inc. -- ANGLE (NVIDIA Quadro M2000 Direct3D11 vs_5_0 ps_5_0)
WebGL 1 Driver Version: OpenGL ES 2.0 (ANGLE 2.1.0.dec065540d5f)
WebGL 1 Driver Extensions: GL_ANGLE_depth_texture GL_ANGLE_framebuffer_blit GL_ANGLE_framebuffer_multisample GL_ANGLE_instanced_arrays GL_ANGLE_lossy_etc_decode GL_ANGLE_pack_reverse_row_order GL_ANGLE_request_extension GL_ANGLE_robust_client_memory GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_ANGLE_texture_usage GL_ANGLE_translated_shader_source GL_CHROMIUM_bind_generates_resource GL_CHROMIUM_bind_uniform_location GL_CHROMIUM_copy_compressed_texture GL_CHROMIUM_copy_texture GL_CHROMIUM_sync_query GL_EXT_blend_minmax GL_EXT_color_buffer_half_float GL_EXT_debug_marker GL_EXT_discard_framebuffer GL_EXT_disjoint_timer_query GL_EXT_draw_buffers GL_EXT_frag_depth GL_EXT_map_buffer_range GL_EXT_occlusion_query_boolean GL_EXT_read_format_bgra GL_EXT_robustness GL_EXT_sRGB GL_EXT_shader_texture_lod GL_EXT_texture_compression_dxt1 GL_EXT_texture_filter_anisotropic GL_EXT_texture_format_BGRA8888 GL_EXT_texture_rg GL_EXT_texture_storage GL_EXT_unpack_subimage GL_KHR_debug GL_NV_EGL_stream_consumer_external GL_NV_fence GL_NV_pack_subimage GL_NV_pixel_buffer_object GL_OES_EGL_image GL_OES_EGL_image_external GL_OES_compressed_ETC1_RGB8_texture GL_OES_depth32 GL_OES_element_index_uint GL_OES_get_program_binary GL_OES_mapbuffer GL_OES_packed_depth_stencil GL_OES_rgb8_rgba8 GL_OES_standard_derivatives GL_OES_texture_float GL_OES_texture_float_linear GL_OES_texture_half_float GL_OES_texture_half_float_linear GL_OES_texture_npot GL_OES_vertex_array_object
WebGL 1 Extensions: ANGLE_instanced_arrays EXT_blend_minmax EXT_color_buffer_half_float EXT_frag_depth EXT_shader_texture_lod EXT_texture_filter_anisotropic EXT_disjoint_timer_query MOZ_debug OES_element_index_uint OES_standard_derivatives OES_texture_float OES_texture_float_linear OES_texture_half_float OES_texture_half_float_linear OES_vertex_array_object WEBGL_color_buffer_float WEBGL_compressed_texture_s3tc WEBGL_debug_renderer_info WEBGL_debug_shaders WEBGL_depth_texture WEBGL_draw_buffers WEBGL_lose_context MOZ_WEBGL_lose_context MOZ_WEBGL_compressed_texture_s3tc MOZ_WEBGL_depth_texture
WebGL 2 Driver WSI Info: EGL_VENDOR: Google Inc. (adapter LUID: 0000000000010a60) EGL_VERSION: 1.4 (ANGLE 2.1.0.dec065540d5f) EGL_EXTENSIONS: EGL_EXT_create_context_robustness EGL_ANGLE_d3d_share_handle_client_buffer EGL_ANGLE_d3d_texture_client_buffer EGL_ANGLE_surface_d3d_texture_2d_share_handle EGL_ANGLE_query_surface_pointer EGL_ANGLE_window_fixed_size EGL_ANGLE_keyed_mutex EGL_ANGLE_surface_orientation EGL_ANGLE_direct_composition EGL_NV_post_sub_buffer EGL_KHR_create_context EGL_EXT_device_query EGL_KHR_image EGL_KHR_image_base EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_get_all_proc_addresses EGL_KHR_stream EGL_KHR_stream_consumer_gltexture EGL_NV_stream_consumer_gltexture_yuv EGL_ANGLE_flexible_surface_compatibility EGL_ANGLE_stream_producer_d3d_texture_nv12 EGL_ANGLE_create_context_webgl_compatibility EGL_CHROMIUM_create_context_bind_generates_resource EGL_EXTENSIONS(nullptr): EGL_EXT_client_extensions EGL_EXT_platform_base EGL_EXT_platform_device EGL_ANGLE_platform_angle EGL_ANGLE_platform_angle_d3d EGL_ANGLE_device_creation EGL_ANGLE_device_creation_d3d11 EGL_ANGLE_experimental_present_path EGL_KHR_client_get_all_proc_addresses
WebGL 2 Driver Renderer: Google Inc. -- ANGLE (NVIDIA Quadro M2000 Direct3D11 vs_5_0 ps_5_0)
WebGL 2 Driver Version: OpenGL ES 3.0 (ANGLE 2.1.0.dec065540d5f)
WebGL 2 Driver Extensions: GL_ANGLE_depth_texture GL_ANGLE_framebuffer_blit GL_ANGLE_framebuffer_multisample GL_ANGLE_instanced_arrays GL_ANGLE_lossy_etc_decode GL_ANGLE_pack_reverse_row_order GL_ANGLE_request_extension GL_ANGLE_robust_client_memory GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_ANGLE_texture_usage GL_ANGLE_translated_shader_source GL_CHROMIUM_bind_generates_resource GL_CHROMIUM_bind_uniform_location GL_CHROMIUM_copy_compressed_texture GL_CHROMIUM_copy_texture GL_CHROMIUM_sync_query GL_EXT_blend_minmax GL_EXT_color_buffer_float GL_EXT_color_buffer_half_float GL_EXT_debug_marker GL_EXT_discard_framebuffer GL_EXT_disjoint_timer_query GL_EXT_draw_buffers GL_EXT_frag_depth GL_EXT_map_buffer_range GL_EXT_occlusion_query_boolean GL_EXT_read_format_bgra GL_EXT_robustness GL_EXT_sRGB GL_EXT_shader_texture_lod GL_EXT_texture_compression_dxt1 GL_EXT_texture_filter_anisotropic GL_EXT_texture_format_BGRA8888 GL_EXT_texture_norm16 GL_EXT_texture_rg GL_EXT_texture_storage GL_EXT_unpack_subimage GL_KHR_debug GL_NV_EGL_stream_consumer_external GL_NV_fence GL_NV_pack_subimage GL_NV_pixel_buffer_object GL_OES_EGL_image GL_OES_EGL_image_external GL_OES_EGL_image_external_essl3 GL_OES_compressed_ETC1_RGB8_texture GL_OES_depth32 GL_OES_element_index_uint GL_OES_get_program_binary GL_OES_mapbuffer GL_OES_packed_depth_stencil GL_OES_rgb8_rgba8 GL_OES_standard_derivatives GL_OES_texture_float GL_OES_texture_float_linear GL_OES_texture_half_float GL_OES_texture_half_float_linear GL_OES_texture_npot GL_OES_vertex_array_object
WebGL 2 Extensions: EXT_color_buffer_float EXT_texture_filter_anisotropic EXT_disjoint_timer_query MOZ_debug OES_texture_float_linear WEBGL_compressed_texture_s3tc WEBGL_debug_renderer_info WEBGL_debug_shaders WEBGL_lose_context MOZ_WEBGL_lose_context MOZ_WEBGL_compressed_texture_s3tc
Audio Backend: wasapi
Direct2D: true
DirectWrite: true (10.0.15063.413)
GPU #1
Active: Yes
Description: NVIDIA Quadro M2000
Vendor ID: 0x10de
Device ID: 0x1430
Driver Version: 21.21.13.6909
Driver Date: 8-1-2016
Drivers: C:\WINDOWS\System32\DriverStore\FileRepository\nvlw.inf_amd64_209d618eb433ea8c\nvd3dumx,C:\WINDOWS\System32\DriverStore\FileRepository\nvlw.inf_amd64_209d618eb433ea8c\nvwgf2umx,C:\WINDOWS\System32\DriverStore\FileRepository\nvlw.inf_amd64_209d618eb433ea8c\nvwgf2umx,C:\WINDOWS\System32\DriverStore\FileRepository\nvlw.inf_amd64_209d618eb433ea8c\nvwgf2umx C:\WINDOWS\System32\DriverStore\FileRepository\nvlw.inf_amd64_209d618eb433ea8c\nvd3dum,C:\WINDOWS\System32\DriverStore\FileRepository\nvlw.inf_amd64_209d618eb433ea8c\nvwgf2um,C:\WINDOWS\System32\DriverStore\FileRepository\nvlw.inf_amd64_209d618eb433ea8c\nvwgf2um,C:\WINDOWS\System32\DriverStore\FileRepository\nvlw.inf_amd64_209d618eb433ea8c\nvwgf2um
Subsys ID: 119010de
RAM: 4096

Diagnostics
AzureCanvasAccelerated: 0
AzureCanvasBackend: Direct2D 1.1
AzureCanvasBackend (UI Process): skia
AzureContentBackend: Direct2D 1.1
AzureContentBackend (UI Process): skia
AzureFallbackCanvasBackend (UI Process): cairo
GPUProcessPid: 13852
GPUProcess: Terminate GPU Process
Device Reset: Trigger Device Reset
Decision Log
WEBRENDER:
opt-in by default: WebRender is an opt-in feature
ADVANCED_LAYERS:
disabled by default: Disabled by default




Important Modified Preferences
------------------------------

accessibility.typeaheadfind.flashBar: 0
browser.cache.disk.capacity: 358400
browser.cache.disk.filesystem_reported: 1
browser.cache.disk.smart_size.first_run: false
browser.cache.disk.smart_size.use_old_max: false
browser.cache.frecency_experiment: 3
browser.download.manager.alertOnEXEOpen: true
browser.places.smartBookmarksVersion: 8
browser.sessionstore.upgradeBackup.latestBuildID: 20170707030206
browser.startup.homepage: about:home
browser.startup.homepage_override.buildID: 20170707030206
browser.startup.homepage_override.mstone: 56.0a1
browser.tabs.warnOnClose: false
browser.urlbar.daysBeforeHidingSuggestionsPrompt: 0
browser.urlbar.lastSuggestionsPromptDate: 20170524
browser.urlbar.maxRichResults: 12
browser.urlbar.timesBeforeHidingSuggestionsHint: 0
browser.urlbar.usepreloadedtopurls.enabled: false
dom.fetchController.enabled: true
dom.fetchObserver.enabled: true
dom.push.userAgentID: b21172d82b9d4a73b46c5915fc4e2464
dom.timeout.max_consecutive_callbacks: 9999
extensions.lastAppVersion: 56.0a1
font.internaluseonly.changed: true
media.gmp-gmpopenh264.abi: x86_64-msvc-x64
media.gmp-gmpopenh264.lastUpdate: 1489699177
media.gmp-gmpopenh264.version: 1.6
media.gmp-manager.buildID: 20170707030206
media.gmp-manager.lastCheck: 1499436042
media.gmp-widevinecdm.abi: x86_64-msvc-x64
media.gmp-widevinecdm.lastUpdate: 1489699179
media.gmp-widevinecdm.version: 1.4.8.903
media.gmp.storage.version.observed: 1
media.hardware-video-decoding.failed: true
network.cookie.prefsMigrated: true
network.predictor.cleaned-up: true
places.database.lastMaintenance: 1499261148
places.history.expiration.transient_current_max_pages: 109417
plugin.disable_full_page_plugin_for_types: application/pdf
print.printer_Microsoft_Print_to_PDF.print_bgcolor: false
print.printer_Microsoft_Print_to_PDF.print_bgimages: false
print.printer_Microsoft_Print_to_PDF.print_duplex: -437918235
print.printer_Microsoft_Print_to_PDF.print_edge_bottom: 0
print.printer_Microsoft_Print_to_PDF.print_edge_left: 0
print.printer_Microsoft_Print_to_PDF.print_edge_right: 0
print.printer_Microsoft_Print_to_PDF.print_edge_top: 0
print.printer_Microsoft_Print_to_PDF.print_evenpages: true
print.printer_Microsoft_Print_to_PDF.print_footercenter:
print.printer_Microsoft_Print_to_PDF.print_footerleft: &PT
print.printer_Microsoft_Print_to_PDF.print_footerright: &D
print.printer_Microsoft_Print_to_PDF.print_headercenter:
print.printer_Microsoft_Print_to_PDF.print_headerleft: &T
print.printer_Microsoft_Print_to_PDF.print_headerright: &U
print.printer_Microsoft_Print_to_PDF.print_in_color: true
print.printer_Microsoft_Print_to_PDF.print_margin_bottom: 0.5
print.printer_Microsoft_Print_to_PDF.print_margin_left: 0.5
print.printer_Microsoft_Print_to_PDF.print_margin_right: 0.5
print.printer_Microsoft_Print_to_PDF.print_margin_top: 0.5
print.printer_Microsoft_Print_to_PDF.print_oddpages: true
print.printer_Microsoft_Print_to_PDF.print_orientation: 0
print.printer_Microsoft_Print_to_PDF.print_page_delay: 50
print.printer_Microsoft_Print_to_PDF.print_paper_data: 0
print.printer_Microsoft_Print_to_PDF.print_paper_height: 11.00
print.printer_Microsoft_Print_to_PDF.print_paper_name:
print.printer_Microsoft_Print_to_PDF.print_paper_size_unit: 0
print.printer_Microsoft_Print_to_PDF.print_paper_width: 8.50
print.printer_Microsoft_Print_to_PDF.print_resolution: -437918235
print.printer_Microsoft_Print_to_PDF.print_reversed: false
print.printer_Microsoft_Print_to_PDF.print_scaling: 1.00
print.printer_Microsoft_Print_to_PDF.print_shrink_to_fit: true
print.printer_Microsoft_Print_to_PDF.print_to_file: false
print.printer_Microsoft_Print_to_PDF.print_unwriteable_margin_bottom: 0
print.printer_Microsoft_Print_to_PDF.print_unwriteable_margin_left: 0
print.printer_Microsoft_Print_to_PDF.print_unwriteable_margin_right: 0
print.printer_Microsoft_Print_to_PDF.print_unwriteable_margin_top: 0
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_bgcolor: false
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_bgimages: false
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_duplex: -437918235
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_edge_bottom: 0
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_edge_left: 0
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_edge_right: 0
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_edge_top: 0
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_evenpages: true
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_footercenter:
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_footerleft: &PT
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_footerright: &D
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_headercenter:
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_headerleft: &T
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_headerright: &U
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_in_color: true
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_margin_bottom: 0.5
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_margin_left: 0.5
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_margin_right: 0.5
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_margin_top: 0.5
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_oddpages: true
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_orientation: 0
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_page_delay: 50
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_paper_data: 1
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_paper_height: -1.00
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_paper_name:
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_paper_size_unit: 0
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_paper_width: -1.00
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_resolution: 600
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_reversed: false
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_scaling: 1.00
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_shrink_to_fit: true
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_to_file: false
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_unwriteable_margin_bottom: 0
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_unwriteable_margin_left: 0
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_unwriteable_margin_right: 0
print.printer_Xerox_Phaser_6128MFP-N_Class_Driver.print_unwriteable_margin_top: 0
privacy.donottrackheader.enabled: true
security.sandbox.content.tempDirSuffix: {8fcc9e07-dc16-4e8e-b080-4f1ffdc3496d}
security.tls.version.min: 0
services.sync.declinedEngines: addons
services.sync.engine.addons: false
services.sync.engine.bookmarks.validation.lastTime: 1499435768
services.sync.engine.passwords: false
services.sync.engine.prefs.modified: false
services.sync.lastPing: 1499435766
services.sync.lastSync: Fri Jul 07 2017 10:32:32 GMT-0400 (Eastern Standard Time)
storage.vacuum.last.index: 1
storage.vacuum.last.places.sqlite: 1497575589
ui.osk.debug.keyboardDisplayReason: IKPOS: Touch screen not found.

Important Locked Preferences
----------------------------

Places Database
---------------

JavaScript
----------

Incremental GC: true

Accessibility
-------------

Activated: false
Prevent Accessibility: 0
Accessible Handler Used: true

Library Versions
----------------

NSPR
Expected minimum version: 4.16 Beta
Version in use: 4.16 Beta

NSS
Expected minimum version: 3.32 Beta
Version in use: 3.32 Beta

NSSSMIME
Expected minimum version: 3.32 Beta
Version in use: 3.32 Beta

NSSSSL
Expected minimum version: 3.32 Beta
Version in use: 3.32 Beta

NSSUTIL
Expected minimum version: 3.32 Beta
Version in use: 3.32 Beta

Experimental Features
---------------------

Name: Animated Image Discarding Nightly 55
ID: [e-mail]
Description: Measures the impact of enabling animate image discarding in Firefox Nightly 55
Active: false
End Date: 1494720000011
Homepage:
Branch: control

Sandbox
-------

Content Process Sandbox Level: 2
Effective Content Process Sandbox Level: 2

Comment 1

[Dave Townsend [:mossop]]

I expect that this is intentional since bug 1196266 where we follow the OS title bar colours. The OS settings app for example does the same thing.

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

(In reply to Dave Townsend [:mossop] from comment #1)
> I expect that this is intentional since bug 1196266 where we follow the OS
> title bar colours. The OS settings app for example does the same thing.

I don't get any title bar color changes on the windows 10 settings app.  In fact, I can't find any other app on my win10 machine which does anything like this.

Comment 3

[Dave Townsend [:mossop]]

If you right click on the desktop, go to Personalize and then Colors on the left hand side, do you have "Title bars" checked under "Show accent color on the following surfaces". The other settings in that pane might be useful to know too.

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

(In reply to Dave Townsend [:mossop] from comment #3)
> If you right click on the desktop, go to Personalize and then Colors on the
> left hand side, do you have "Title bars" checked under "Show accent color on
> the following surfaces". The other settings in that pane might be useful to
> know too.

Ok.  That does cause the title bar to change on other apps when focus is applied.

But... why does firefox do this even when I don't have the option checked?  And why does firefox not use the same accent color as other apps when the setting is enabled?

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

Also, I get some glitches with this behavior.  Try this:

1. Open two browser windows.  Lets call them A and B.
2. Pin some tabs in window A.
3. Focus one of the pinned tabs in window A.
4. Focus window B.
5. Select one of the other pinned tabs in window A.

I get a short flash painting the previously focused tab with the light background color before its repainted with the dark focused color.

Comment 6

[Dave Townsend [:mossop]]

(In reply to Ben Kelly [reviewing, but slowly][:bkelly] from comment #4)
> (In reply to Dave Townsend [:mossop] from comment #3)
> > If you right click on the desktop, go to Personalize and then Colors on the
> > left hand side, do you have "Title bars" checked under "Show accent color on
> > the following surfaces". The other settings in that pane might be useful to
> > know too.
> 
> Ok.  That does cause the title bar to change on other apps when focus is
> applied.
> 
> But... why does firefox do this even when I don't have the option checked?

That is probably a bug.

> And why does firefox not use the same accent color as other apps when the
> setting is enabled?

It does for me.

Sounds like you have a few different bugs going on here. Might be worth morphing this to one of them and filing new bugs for the others.

Comment 7

[Ben Kelly [:bkelly, not reviewing]]

Dao, can you take a look at these issues?

Comment 8

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Screenshot 2017-07-07 15.51.56.png

Also I would note that the new "tab has activity" indicator that was just changed to match our dark theme looks quite bad when the unfocused light color is forced.  See this screenshot.

Comment 9

[Dave Townsend [:mossop]]

(In reply to Ben Kelly [reviewing, but slowly][:bkelly] from comment #5)
> Also, I get some glitches with this behavior.  Try this:
> 
> 1. Open two browser windows.  Lets call them A and B.
> 2. Pin some tabs in window A.
> 3. Focus one of the pinned tabs in window A.
> 4. Focus window B.
> 5. Select one of the other pinned tabs in window A.
> 
> I get a short flash painting the previously focused tab with the light
> background color before its repainted with the dark focused color.

Is this the same as bug 1379268?

Comment 10

[Ben Kelly [:bkelly, not reviewing]]

Definitely related.  The slowness is similar to the double paint thing I describe in comment 5.

I think the changing colors when accent title is disabled is a separate bug from the slowness, though.

Comment 11

[Dão Gottwald [:dao]]

Attachment: Bug 1379173 - Don't drop the custom titlebar color in inactive windows.

Review commit: https://reviewboard.mozilla.org/r/155324/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/155324/

Comment 12

[Johann Hofmann [:johannh]]

Comment on attachment 8884412 [details]
Bug 1379173 - Don't drop the custom titlebar color in inactive windows.

https://reviewboard.mozilla.org/r/155324/#review160378

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb672269322d
Don't drop the custom titlebar color in inactive windows. r=johannh

Comment 14

[Masatoshi Kimura [:emk]]

Other Windows apps do not keep the accent color in inactive windows. Why we do it? It makes it impossible to visually differentiate the active window from inactive windows. It will defeat the purpose of accent color.

Comment 15

[Johann Hofmann [:johannh]]

(In reply to Masatoshi Kimura [:emk] from comment #14)
> Other Windows apps do not keep the accent color in inactive windows. Why we
> do it? It makes it impossible to visually differentiate the active window
> from inactive windows. It will defeat the purpose of accent color.

The patch only reverted the behavior for when there's no accent color set. :)

Comment 17

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/bb672269322d

Comment 18

[Ionuț Goldan [:igoldan]]

Thanfully, this brought an improvement:

== Change summary for alert #7775 (as of July 07 2017 20:40 UTC) ==

Improvements:

  5%  tpaint summary windows10-64 opt e10s     298.24 -> 282.38

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=7775

Comment 19

[ovidiu boca[:Ovidiu]]

Hi Dão can you tell me please what should we verify here? Thanks

Comment 20

[Dão Gottwald [:dao]]

(In reply to ovidiu boca[:Ovidiu] from comment #19)
> Hi Dão can you tell me please what should we verify here? Thanks

See comment 0. The title bar shouldn't lose its color in background windows. This is with accent colors in the title bar (the Windows 10 setting) disabled.

Comment 21

[ovidiu boca[:Ovidiu]]

I verified this on Windows 10 with FF Nightly 57.0a1(2017-08-15) and the title bar keeps the background window color. I will mark this as verified fixed. Thanks, Dão.