1379295 - [macOS] Show all history sidebar (using vibrancy on osx) is unreadable when using the default theme

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Marcia Knous [:marcia]]

Attachment: Screen Shot 2017-07-07 at 6.03.41 PM.png

Seen while running Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:55.0) Gecko/20100101 Firefox/55.0 ID:20170706085508 CSet: 1ae7e516e5dae3c0b537251781e1adeb50783131

Webrender is enabled in this profile.

STR:
1. At some point I switched themes from Ocean Ice back to the default theme. Restarted Nightly.
2. History | Show All History - observe the attached screenshot.

In the last hour I upgraded my machine from 10.12 -> 10.13, so that is the only major change made to this machine.

Not able to yet reproduce in another nightly profile on the same machine.

Comment 1

[Stephen Horlander [:shorlander]]

I see the same thing if I set gfx.webrender.enabled to true.

Looks like it breaks -moz-mac-vibrancy

Comment 2

[:Gijs (he/him)]

Markus, I don't know where this goes on the cocoa/webrender/graphics spectrum - can you help triage / find an owner if this is something we intend to ship (haven't stayed on top of webrender, I'm afraid) ? :-)

Comment 3

[Markus Stange [:mstange]]

This falls squarely within the graphics/webrender component: WebRender needs to support OP_SOURCE on ColorLayers.

This requires https://github.com/servo/webrender/issues/1416 .

Comment 4

[Markus Stange [:mstange]]

Attachment: Bug 1379295 - Support vibrancy and rounded window corners with WebRender.

Review commit: https://reviewboard.mozilla.org/r/192150/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192150/

Comment 5

[Markus Stange [:mstange]]

Attachment: Bug 1379295 - Support vibrancy with webrender.

Review commit: https://reviewboard.mozilla.org/r/192728/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192728/

Comment 6

[Markus Stange [:mstange]]

With layers-free, sidebars are no longer unreadable. I'm going to use bug 1386162 for implementing vibrancy with WebRender.