Closed
Bug 1379308
Opened 7 years ago
Closed 7 years ago
Improve the hash key generation for two of the hashtables in nsCSSRuleProcessor.cpp
Categories
(Core :: Layout, enhancement)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
Details
Attachments
(1 obsolete file)
After encountering bug 1379282 I was looking for other examples of simplistic hash functions in the code base and there are two in this file.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8884456 -
Flags: review?(mats)
|
|
Assignee | |
Comment 2•7 years ago
|
||
Comment on attachment 8884456 [details] [diff] [review] Improve the hash key generation for two of the hashtables in nsCSSRuleProcessor.cpp Sorry didn't mean to attach the patch. This hasn't been tested.
Attachment #8884456 -
Attachment is obsolete: true
Attachment #8884456 -
Flags: review?(mats)
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → ehsan
|
||
Comment 3•7 years ago
|
||
It looks like the right fix though, so r=mats if you want it :-)
|
|
Assignee | |
Comment 4•7 years ago
|
||
Heh, thanks! :-) The patch is on try. I'll land it if it turns out green!
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/575bde4cd0ac Improve the hash key generation for two of the hashtables in nsCSSRuleProcessor.cpp; r=mats
|
||
Comment 6•7 years ago
|
||
| bugherder landing | ||
https://hg.mozilla.org/integration/autoland/rev/575bde4cd0ac
|
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/575bde4cd0ac
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•