1379704 - Update update-jsoncpp.sh to match new location of jsoncpp

Status: RESOLVED FIXED

(Core :: WebVR, enhancement, P2)

Description

[:kip (Kearwood Gilbert)]

In bug 1356382, jsoncpp was moved from toolkit/crashreporter to toolkit/components.

As per Bug 1356382 Comment 14, the update-jsoncpp.sh script should be be updated to reflect the new location.

Comment 1

[:kip (Kearwood Gilbert)]

In addition to updating the script, it should be moved from toolkit/crashreporter to toolkit/components

Comment 2

[:kip (Kearwood Gilbert)]

Attachment: Bug 1379704 - Move and update update-jsoncpp.sh script to match new location of jsoncpp library

- In bug 1356382, jsoncpp was moved from toolkit/crashreporter
  to toolkit/components
- update-jsoncpp.sh has been moved to the components directory
  and updated to match the new directories.

Review commit: https://reviewboard.mozilla.org/r/155812/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/155812/

Comment 3

[Christian Holler (:decoder)]

I canceled review here because I can't review this. I suggest pinging one of the build/crashreporter/toolkit peers, maybe :ted or :froydnj. But both are on PTO right now, so you might have to wait.

Comment 4

[:kip (Kearwood Gilbert)]

This will need to land in FF58+

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Ted, can you rubberstamp this?

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 8884985 [details]
Bug 1379704 - Move and update update-jsoncpp.sh script to match new location of jsoncpp library

https://reviewboard.mozilla.org/r/155812/#review265468

Seems straightforward. We should add a moz.yaml file for this at some point.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d268f4ed8a3
Move and update update-jsoncpp.sh script to match new location of jsoncpp library r=ted

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4d268f4ed8a3