Closed Bug 1379755 Opened 7 years ago Closed 6 years ago

gflags.cc contains an unused function

Categories

(Core :: WebRTC, defect, P5)

Product:
Core
Component:
WebRTC
Version:
56 Branch
Platform:
x86_64
Linux
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: sophietheopossum, Unassigned)

Details

(Whiteboard: [needinfo 2017-07-18 to reporter])

Attachments

(1 file)

gflags.cc
71.47 KB, patch
Details | Diff | Splinter Review 
+++ This bug was initially created as a clone of Bug #1379738 +++

+++ This bug was initially created as a clone of Bug #1379502 +++

+++ This bug was initially created as a clone of Bug #1379494 +++

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20170709180027

Steps to reproduce:

compiled firefox


Actual results:

"warning: ‘int google::{anonymous}::FlagValue::ValueSize() const’ defined but not used [-Wunused-function]
 1:39.51  int FlagValue::ValueSize() const {"


Expected results:

no error reported
Attached patch gflags.cc — — Splinter Review 
removed unused function
Component: Untriaged → WebRTC
I check latest build logs from here [0] and I do not see the warning. Are you sure this is not something appears locally?

[0] https://public-artifacts.taskcluster.net/Ua8TBTDISziKDOwwoML6iQ/0/public/logs/live_backing.log
Flags: needinfo?(goldsnakeking)
Whiteboard: [needinfo 2017-07-18 to reporter]
perhaps it is fixed; i'll check later
Rank: 55
Priority: -- → P5
sorry for the long while replying; as of right now anyway.. it appears to be fixed as i don't get the warning anymore, so i would imagine it can be marked as resolved for now
Flags: needinfo?(goldsnakeking)
Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: