1379955 - Can't find OnboardingTourType.jsm when rewriting lcov files

Status: RESOLVED FIXED

(Testing :: Code Coverage, defect)

Description

[Marco Castelluccio [:marco]]

Traceback (most recent call last):
  File "python/mozbuild/mozbuild/codecoverage/lcov_rewriter.py", line 731, in <module>
    main()
  File "python/mozbuild/mozbuild/codecoverage/lcov_rewriter.py", line 728, in main
    rewriter.rewrite_file(f, args.output_suffix)
  File "python/mozbuild/mozbuild/codecoverage/lcov_rewriter.py", line 675, in rewrite_file
    assert os.path.isfile(source_file), "Couldn\'t find mapped source file at %s!" % source_file
AssertionError: Couldn\'t find mapped source file at /home/marco/Documenti/FD/mozilla-unified/browser/extensions/onboarding/content/modules/OnboardingTourType.jsm!

The SF entry is "resource://onboarding/modules/OnboardingTourType.jsm".

The module can be found at "browser/extensions/onboarding/OnboardingTourType.jsm".

Comment 1

[Marco Castelluccio [:marco]]

This is causing the rewriting to fail, as this SF is in a lot of lcov files.

Chris, can you take a look?

Comment 2

[Marco Castelluccio [:marco]]

Attachment: 1499742942-8792-0.info.bz2

This is an example lcov file containing OnboardingTourType.jsm.

Comment 3

[Marco Castelluccio [:marco]]

In the chrome-map.json file we have these entries:

"resource://onboarding/": [
      "dist/bin/browser/features/[e-mail]/chrome/content"

and:

"dist/bin/browser/features/[e-mail]/chrome/content/": [
      "/home/marco/Documenti/FD/mozilla-unified/browser/extensions/onboarding/content/*",

Comment 4

[Marco Castelluccio [:marco]]

There's also:

"dist/bin/browser/features/[e-mail]/chrome/content/modules/": [
      "/home/marco/Documenti/FD/mozilla-unified/browser/extensions/onboarding/*.jsm",

I suppose the rewriter should have used this entry instead of the one from comment 3.

Comment 5

[Marco Castelluccio [:marco]]

Attachment: Patch

Using the longest prefix match in _find_install_prefix fixes the issue. Do you believe it could cause other issues to crop up?

Comment 6

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8885281 [details] [diff] [review]
Patch

Review of attachment 8885281 [details] [diff] [review]:
-----------------------------------------------------------------

This makes sense and looks like it will work for now. I guess this could still be an issue if we end up with a jar.mn with something like:

content/modules/ (*.jsm)
content/modules/ (foo/*.jsm)

in this case I think we'd only be able to tell which line was responsible for installing the file by trying each pattern, but I'm not sure that's a concern in practice.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b5eec74e7e5
Use longest prefix match when rewriting lcov entries. r=chmanchester

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3b5eec74e7e5

Comment 9

[Marco Castelluccio [:marco]]

This is happening again, I need to figure out why.

Comment 10

[Marco Castelluccio [:marco]]

Apparently it's happened again because a task was triggered for an old revision of mozilla-central. So it's actually fine.