Closed
Bug 1380071
Opened 7 years ago
Closed 7 years ago
Add GeckoView content module registration mechanics
Categories
(GeckoView :: General, enhancement)
Tracking
(firefox56 fixed)
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: esawin, Assigned: esawin)
References
Details
Attachments
(5 files, 3 obsolete files)
1.09 KB,
patch
|
jchen
:
review+
|
Details | Diff | Splinter Review |
1010 bytes,
patch
|
jchen
:
review+
|
Details | Diff | Splinter Review |
2.85 KB,
patch
|
esawin
:
review+
|
Details | Diff | Splinter Review |
3.07 KB,
patch
|
esawin
:
review+
|
Details | Diff | Splinter Review |
1.64 KB,
patch
|
esawin
:
review+
|
Details | Diff | Splinter Review |
With bug 1372681, we enabled registration of GeckoView modules to avoid handling events which have no active listeners. In this bug we want to extend the same mechanics to frame scripts which are loaded during a GeckoView module's initialization to avoid handling content events without active listeners.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8885383 -
Flags: review?(nchen)
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8885384 -
Flags: review?(nchen)
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8885385 -
Flags: review?(nchen)
Assignee | ||
Comment 4•7 years ago
|
||
Attachment #8885386 -
Flags: review?(nchen)
Assignee | ||
Comment 5•7 years ago
|
||
Attachment #8885387 -
Flags: review?(nchen)
Updated•7 years ago
|
Attachment #8885383 -
Flags: review?(nchen) → review+
Comment 6•7 years ago
|
||
Comment on attachment 8885384 [details] [diff] [review] 0002-Bug-1380071-2.0-Use-content-module-base-class-for-th.patch Review of attachment 8885384 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/chrome/geckoview/GeckoViewContent.js @@ +25,2 @@ > > addMessageListener("GeckoView:DOMFullscreenEntered", this); These calls should use whatever message manager that was passed to the class.
Attachment #8885384 -
Flags: review?(nchen) → review+
Comment 7•7 years ago
|
||
Comment on attachment 8885385 [details] [diff] [review] 0003-Bug-1380071-3.0-Use-content-module-base-class-for-th.patch Review of attachment 8885385 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/chrome/geckoview/GeckoViewScrollContent.js @@ +14,5 @@ > // dump(aMsg); > } > > +class GeckoViewScrollContent extends GeckoViewContentModule { > + init() { Don't need this since we're not doing anything here
Attachment #8885385 -
Flags: review?(nchen) → review+
Updated•7 years ago
|
Attachment #8885386 -
Flags: review?(nchen) → review+
Updated•7 years ago
|
Attachment #8885387 -
Flags: review?(nchen) → review+
Assignee | ||
Comment 8•7 years ago
|
||
Addressed comments.
Attachment #8885383 -
Attachment is obsolete: true
Attachment #8886132 -
Flags: review+
Assignee | ||
Comment 9•7 years ago
|
||
Addressed comments and added missing unregister() override.
Attachment #8885384 -
Attachment is obsolete: true
Assignee | ||
Comment 10•7 years ago
|
||
Addressed comments.
Attachment #8885385 -
Attachment is obsolete: true
Attachment #8886135 -
Flags: review+
Assignee | ||
Updated•7 years ago
|
Attachment #8886134 -
Flags: review+
Comment 11•7 years ago
|
||
Pushed by esawin@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/13a43361f217 [1.1] Add base class for GeckoView content modules. r=jchen https://hg.mozilla.org/integration/mozilla-inbound/rev/99ca35b6467b [2.1] Use content module base class for the GeckoView content module. r=jchen https://hg.mozilla.org/integration/mozilla-inbound/rev/9ef8c2565cb3 [3.1] Use content module base class for the GeckoView scroll module. r=jchen https://hg.mozilla.org/integration/mozilla-inbound/rev/852855d5d2cf [4.0] Delay frame script loading to GeckoView content module registration. r=jchen https://hg.mozilla.org/integration/mozilla-inbound/rev/da0754f7bb57 [5.0] Delay frame script loading to GeckoView scroll module registration. r=jchen
Comment 12•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/13a43361f217 https://hg.mozilla.org/mozilla-central/rev/99ca35b6467b https://hg.mozilla.org/mozilla-central/rev/9ef8c2565cb3 https://hg.mozilla.org/mozilla-central/rev/852855d5d2cf https://hg.mozilla.org/mozilla-central/rev/da0754f7bb57
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Updated•5 years ago
|
Product: Firefox for Android → GeckoView
Updated•5 years ago
|
Target Milestone: Firefox 56 → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•