1380201 - [Fennec][HLS] Make access to mIsPlayerInitDone & mResourceCallback guarded.

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Audio/Video, enhancement, P3)

Description

[Kilik Kuo [:kikuo] (inactive)]

From https://scan4.coverity.com/reports.htm#v27748/p11134/fileInstanceId=22191825&defectInstanceId=4435480&mergedDefectId=147724,  there are 4 unguarded read/write defects (CID : 147724 / 147725 / 147726 / 147727).

It won't lead to an unexpected result, It's better to make them safe.

Comment 1

[Kilik Kuo [:kikuo] (inactive)]

Attachment: Bug 1380201 - Make access to some members in GeckoHlsPlayer guarded.

Review commit: https://reviewboard.mozilla.org/r/156448/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/156448/

Comment 2

[James Cheng[:JamesCheng]]

Comment on attachment 8885596 [details]
Bug 1380201 - Make access to some members in GeckoHlsPlayer guarded.

https://reviewboard.mozilla.org/r/156448/#review161566

Comment 3

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 34c4ded4c997 -d 3b419fb92d30: rebasing 406756:34c4ded4c997 "Bug 1380201 - Make access to some members in GeckoHlsPlayer guarded. r=JamesCheng" (tip)
merging mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/BaseHlsPlayer.java
merging mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/GeckoHlsPlayer.java
warning: conflicts while merging mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/GeckoHlsPlayer.java! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 4

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8885596 [details]
Bug 1380201 - Make access to some members in GeckoHlsPlayer guarded.

https://reviewboard.mozilla.org/r/156448/#review161660

rebase

Comment 5

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8885596 [details]
Bug 1380201 - Make access to some members in GeckoHlsPlayer guarded.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/156448/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/835d645c14f0
Make access to some members in GeckoHlsPlayer guarded. r=JamesCheng

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/835d645c14f0