1380249 - Convert tests within js/xpconnect to comply with new data: URI inheritance model

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement, P2)

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1380249_update_tests_js_xpconnect.patch

Bobby, when flipping the pref |security.data_uri.unique_opaque_origin| we encounter three failing tests within js/xpconnect:
1: js/xpconnect/tests/chrome/test_bug484459.xul
2: js/xpconnect/tests/chrome/test_scriptSettings.xul
3: js/xpconnect/tests/chrome/test_windowProxyDeadWrapper.html

All of those three tests rely on the fact that data: URIs used to be same origin with the including context, which we are about to change. I think the best way to update those tests is to load information from a dummy file which is loaded from the same origin, agreed?

Comment 2

[Bobby Holley (:bholley)]

Comment on attachment 8885603 [details] [diff] [review]
bug_1380249_update_tests_js_xpconnect.patch

Review of attachment 8885603 [details] [diff] [review]:
-----------------------------------------------------------------

Please make a copy of file_empty (which lives in the xpconnect mochitest dir) and use that instead of file_dummy, for consistency (you can remove the comment about other consumers for the chrome-copy, probably). r=me with that

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a26c718cf33
Convert tests within js/xpconnect to comply with new data: URI inheritance model. r=bholley

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5a26c718cf33