Closed
Bug 1380494
Opened 7 years ago
Closed 7 years ago
Some PerformanceTiming object properties are missing from the Object Inspector in the console - getter properties are not supported
Categories
(DevTools :: Console, defect, P1)
DevTools
Console
Tracking
(firefox54 unaffected, firefox55 unaffected, firefox56+ verified)
Tracking | Status | |
---|---|---|
firefox54 | --- | unaffected |
firefox55 | --- | unaffected |
firefox56 | + | verified |
People
(Reporter: cpeterson, Assigned: nchevobbe)
References
Details
(Whiteboard: [reserve-console-html])
[Tracking Requested - why for this release]: This is a regression in Nightly 56 from devtools console bug 1308566. STR: 1. Open devtools console. 2. Enter `performance.timing` at the console and press Enter. RESULT: The PerformanceTiming object is dumped to the console: PerformanceTiming { navigationStart: 1499900753244, unloadEventStart: 0, unloadEventEnd: 0, redirectStart: 0, redirectEnd: 0, fetchStart: 1499900753245, domainLookupStart: 1499900753259, domainLookupEnd: 1499900753334, connectStart: 1499900753335, connectEnd: 1499900753369 } But it is missing some PerformanceTiming properties such as: domComplete domContentLoadedEventEnd domContentLoadedEventStart domInteractive domLoading loadEventEnd loadEventStart requestStart responseEnd responseStart Note these properties are *also* missing from the object dumped in Firefox <= 55, but these properties can be inspected in the variables view column if you click on the PerformanceTiming object in the console. https://developer.mozilla.org/en-US/docs/Web/API/PerformanceTiming
Updated•7 years ago
|
Whiteboard: [console-html] [triage]
Comment 1•7 years ago
|
||
Thanks for the report. This isn't a problem in the debugger if I enter `performance.timing` as a watch expression (I see domComplete, etc). Jason, do you have an idea why the debuggers's Object Inspector is showing more information than the console's?
Flags: needinfo?(jlaster)
Updated•7 years ago
|
Flags: qe-verify+
Priority: -- → P2
QA Contact: iulia.cristescu
Whiteboard: [console-html] [triage] → [console-html]
Comment 2•7 years ago
|
||
That's because these properties are accessor properties, not data properties. See bug 1380504.
Comment 3•7 years ago
|
||
We currently set getter properties and properties for the OI. We probably could do something in the Object Inspector to support getters separately, but that was out of scope at the time. https://github.com/devtools-html/debugger.html/blob/master/src/client/firefox/commands.js#L196-L199
Flags: needinfo?(jlaster)
Comment 4•7 years ago
|
||
OK, going to dupe Bug 1380504 to this one since it's already being tracked for 56. This will be fixed in Reps at https://github.com/devtools-html/devtools-core/issues/397
Summary: Some PerformanceTiming object properties are missing from the Object Inspector in the console → Some PerformanceTiming object properties are missing from the Object Inspector in the console - getter properties are not supported
Updated•7 years ago
|
Priority: P2 → P3
Whiteboard: [console-html] → [reserve-console-html]
Comment 7•7 years ago
|
||
This is fixed on m-c in Bug 1380790, will wait until it hits Nightly tomorrow for confirmation
Assignee | ||
Comment 8•7 years ago
|
||
The fix landed in latest Nightly (56.0a1 (2017-07-28)), Chris, is it working as expected for you ?
Flags: needinfo?(cpeterson)
Reporter | ||
Comment 9•7 years ago
|
||
(In reply to Nicolas Chevobbe [:nchevobbe] from comment #8) > The fix landed in latest Nightly (56.0a1 (2017-07-28)), Chris, is it working > as expected for you ? Yes. I see domComplete and the other missing performance.timing properties when I expand the PerformanceTiming object's list of properties. It would be nice if all the properties were listed in the compact object representation, but this is the current behavior as Firefox 54 so this regression has been fixed. compact object representation: PerformanceTiming { navigationStart: 1501259972917, unloadEventStart: 0, unloadEventEnd: 0, redirectStart: 0, redirectEnd: 0, fetchStart: 1501259972918, domainLookupStart: 1501259972918, domainLookupEnd: 1501259972918, connectStart: 1501259972918, connectEnd: 1501259972918 } expanded property list: connectEnd : 1501259972918 connectStart : 1501259972918 domComplete : 1501259974344 domContentLoadedEventEnd : 1501259974291 domContentLoadedEventStart : 1501259974213 domInteractive : 1501259974151 domLoading : 1501259973963 domainLookupEnd : 1501259972918 domainLookupStart : 1501259972918 fetchStart : 1501259972918 loadEventEnd : 1501259974345 loadEventStart : 1501259974344 navigationStart : 1501259972917 redirectEnd : 0 redirectStart : 0 requestStart : 1501259972993 responseEnd : 1501259973953 responseStart : 1501259973923 secureConnectionStart : 1501259972917 timeToNonBlankPaint : 1501259974180 unloadEventEnd : 0 unloadEventStart : 0
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(cpeterson)
Resolution: --- → FIXED
Updated•7 years ago
|
Status: RESOLVED → VERIFIED
Iteration: --- → 56.4 - Aug 1
Flags: qe-verify+
Priority: P3 → P1
Updated•7 years ago
|
Assignee: nobody → nchevobbe
Target Milestone: --- → Firefox 56
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•