1380818 - Show the addon id in about:debugging

Status: VERIFIED FIXED

(DevTools :: about:debugging, enhancement, P5)

Description

[Andy McKay]

We should show the add-on id in about:debugging. If the developer has specified it, then they will know what it is. But since we made applications > gecko > id optional we assign to the add-on in a couple of scenarios 1) during about:debugging as a temporary loading and 2) when signed by AMO.

Notably nativeMessaging needs this id.

So an add-on author might not know it, its simple to add so lets do that.

Comment 1

[Andy McKay]

Attachment: extension-id.PNG

Comment 2

[Andy McKay]

Attachment: bug 1380818 show the add-on id on about:debugging

Review commit: https://reviewboard.mozilla.org/r/157574/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157574/

Comment 3

[Julian Descottes [:jdescottes]]

Comment on attachment 8886782 [details]
bug 1380818 show the add-on id on about:debugging

https://reviewboard.mozilla.org/r/157574/#review162862

Looks great! 

Just a small unrelated thing I noticed: the addon title is smaller than the rest of the text. 
Maybe we should make it bold (same as in about:addons ?) to make it more noticeable?

Comment 4

[Andy McKay]

I've seen an image from mstriemer that changes a few things and I think it changes the text under the title. Not sure which bug that is though.

Comment 5

[Mark Striemer [:mstriemer]]

The add-on title is indeed supposed to be bold. Looks like the other text should maybe be smaller as well.

I filed bug 1381550 to fix this.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1dd2fccddf1f
show the add-on id on about:debugging r=jdescottes

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1dd2fccddf1f

Comment 8

[Saddam Hossain]

I have reproduced this Bug on Nightly 56.0a1 (2017-07-13) on Windows 10, 64 bit!

The bug's fix is now verified on latest  Nightly 56.0a1

Build ID    :	20170720030203
User Agent  : 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0

Comment 9

[Md.Tarikul Islam Oashi]

I can see the feature implemented in Nightly 56.0a1 on Linux Mint(64 Bit)

Build ID 	20170720220700
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0

[Bugday-20170719]