1380991 - Tab crash indicator is only shown for the currently selected tab but not for others of the same content process

Status: NEW

(Firefox :: Tabbed Browser, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

[Tracking Requested - why for this release]:

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:56.0) Gecko/20100101 Firefox/56.0 ID:20170714100307 CSet: 67cd1ee26f2661fa5efe3d952485ab3c89af4271

Today I observed that when a tab crashes the crash indicator is only visible for the currently selected tab, but not for others of the same content process which also were killed. Instead the usual tab icon displays the status as usual, and the user is left in the assumption that the tab is still working. As result background services like IRC are not running, until the user clicks the tab again which will trigger a reload.

Steps:

1. Open several tabs
2. Install Nightly tester tools or the crashme extension
3. Kill the content process of a tab

After step 3 all the tabs which were killed should display the crash indicator and not only the current one.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Hi Chris, could you please have a look and tell me if that is intended or not? It feels odd not being informed about unloads of browsers in other tabs due to a crash.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I got informed about bug 1209689 which seems to have changed the behavior for Firefox 45. Feedback from UX might also be nice.

Comment 3

[Chris Peterson [:cpeterson]]

(In reply to Henrik Skupin (:whimboo) [partly available 07/10 -07/14] from comment #1)
> Hi Chris, could you please have a look and tell me if that is intended or
> not? It feels odd not being informed about unloads of browsers in other tabs
> due to a crash.

I don't know. Philipp is the right person to make the call.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

FYI I can see that there is a "Restore all crashed tabs" button available when a tab crashes, but this is not working at all. I still have to select each individual tab to get it restored.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

To be clear, "Restore all crashed tabs" means to restore each tab that shows the about:tabcrashed page. At the current time, it is only possible for multiple about:tabcrashed pages to show if there are multiple windows open, since the selected tabs are the only ones that can show about:tabcrashed (since bug 1209689).

(In reply to Henrik Skupin (:whimboo) from comment #2)
> I got informed about bug 1209689 which seems to have changed the behavior
> for Firefox 45. Feedback from UX might also be nice.

This was requested from UX in bug 1209689 comment 2.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

> (In reply to Henrik Skupin (:whimboo) from comment #2)
> > I got informed about bug 1209689 which seems to have changed the behavior
> > for Firefox 45. Feedback from UX might also be nice.
> 
> This was requested from UX in bug 1209689 comment 2.

Which was before we enabled multiple content processes. So when one tab crashed, all others crashed too. But now with different processes this is not the case anymore, and it is hard to find out without any indicator which other browsers don't work anymore because the content process is gone.

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

It sounds like we should let the user know or restore all the crashed tabs -- as Henrik says, this means some pages the user would expect to refresh or give notifications, might not if it shared a content process with a crashed tab.

Comment 8

[Gerry Chang [:gchang]]

We are only 1 week from RC. Mark 56 fix-optional but still happy to have the fix in 56.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Clearing needinfo as Phlsa is no longer at Mozilla

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Sylvestre Ledru [:sylvestre] from comment #10)

Clearing needinfo as Phlsa is no longer at Mozilla

Stephen, is there anyone from ux who could have a look at this bug? Thanks

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit BugBot documentation.