1381437 - Fix racing test case: test_data_uri.html

Status: RESOLVED FIXED

(Core :: Security, defect)

Description

[Henry Chang [:hchang]]

http://searchfox.org/mozilla-central/rev/01d27fdd3946f7210da91b18fcccca01d7324fe2/dom/base/test/test_data_uri.html#82

is not guaranteed to run before 

http://searchfox.org/mozilla-central/rev/01d27fdd3946f7210da91b18fcccca01d7324fe2/dom/base/test/test_data_uri.html#28

so it's not surprising to have error message like the following:

[task 2017-07-17T10:19:15.400501Z] 10:19:15    ERROR - /tests/dom/base/test/test_data_uri.html logged result after SimpleTest.finish(): iframe should have NullPrincipal

Comment 1

[Henry Chang [:hchang]]

Attachment: Bug1381437.patch

Comment 2

[Henry Chang [:hchang]]

Attachment: Bug1381437.patch

Comment 3

[Henry Chang [:hchang]]

Hi Olli,

Since the original reviewer of test_data_uri.html is you, I am firstly
asking for your review :) This test case is racy because of comment 0
and has been fixed by my patch. (I haven't triggered a try run to verify
but I am very confident since it's quite obvious.)

Could you please review my patch? Thanks!

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8887009 [details] [diff] [review]
Bug1381437.patch

Well, the original patch author should review, but I can review too.
rs+

Comment 5

[Henry Chang [:hchang]]

Asking Yoshi for review as well since he is the original author.

Comment 7

[Henry Chang [:hchang]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/728b31173deb9b63a2391b8a00fc4da5f4ab439e
Bug 1381437 - Re-org testing promises to avoid racy tesing result. r=smaug, yoshi

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/728b31173deb