1381834 - Remove old Console front-end

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Entire code base related to the old Console front-end including all preferences should be removed.

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

See also bug 1375778 comment #c8

Honza

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

See also bug 1378850 comment #c8

Honza

Comment 4

[Brian Grinstead [:bgrins]]

Attachment: Bug 1381834 - Remove old Console front-end;

Review commit: https://reviewboard.mozilla.org/r/236114/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/236114/

Comment 5

[Brian Grinstead [:bgrins]]

Comment on attachment 8967444 [details]
Bug 1381834 - Remove old Console front-end;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/236114/diff/1-2/

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8967444 [details]
Bug 1381834 - Remove old Console front-end;

https://reviewboard.mozilla.org/r/236114/#review242128

Looks good to me (and feel soooo good \o/)
I might have missed it, but I don't think we take care of the old frontend prefs (and the new frontend console and browserconsole) from devtools/client/preferences/devtools-client.js ?
Should we do it here or in a follow up ?

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Should we clean devtools/shared/webconsole/server-logger-monitor.js and devtools/shared/webconsole/server-logger.js here ? 
Maybe a follow up would be better since I think there is some actor code

Comment 8

[Brian Grinstead [:bgrins]]

Thanks, I'll make follow ups for your suggestions

Comment 9

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 87a8961b7ee8dd8347e3c3b2b0da19281b001982 -d 40ab295f68f7: rebasing 457869:87a8961b7ee8 "Bug 1381834 - Remove old Console front-end;r=nchevobbe" (tip)
local [dest] changed devtools/client/webconsole/old/test/head.js which other [source] deleted
use (c)hanged version, (d)elete, or leave (u)nresolved? u
merging devtools/client/framework/toolbox-options.js
merging devtools/client/jar.mn
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 10

[Brian Grinstead [:bgrins]]

Comment on attachment 8967444 [details]
Bug 1381834 - Remove old Console front-end;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/236114/diff/2-3/

Comment 11

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 934fb6223874bbbfe5c6755e9a302775f81bab84 -d 1cece7d5df17: rebasing 457871:934fb6223874 "Bug 1381834 - Remove old Console front-end;r=nchevobbe" (tip)
local [dest] changed devtools/client/webconsole/old/test/head.js which other [source] deleted
use (c)hanged version, (d)elete, or leave (u)nresolved? u
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 12

[Brian Grinstead [:bgrins]]

Ah, this needs to land on top of Bug 1453712

Comment 13

[Brian Grinstead [:bgrins]]

Comment on attachment 8967444 [details]
Bug 1381834 - Remove old Console front-end;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/236114/diff/3-4/

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e71c12ebd74
Remove old Console front-end;r=nchevobbe

Comment 15

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/1e71c12ebd74