Closed
Bug 1381930
Opened 7 years ago
Closed 7 years ago
Small JitFrameIterator refactorings
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: bbouvier, Assigned: bbouvier)
Details
Attachments
(2 files)
|
3.56 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
|
33.14 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
Three things have bugged me enough that I wanted to open a bug about them:
- all the non-trivial JitFrameIterator ctors do basically the same thing
- the JitFrameIterator impl is in JitFrames.cpp, while there's a JitFrameIterator{,-inl}.h.
- some inline JitFrameIterator methods are defined in JitFrames-inl.h
|
Assignee | |
Comment 1•7 years ago
|
||
Simple trick: delegate ctors to a private ctor that does the right thing to the most common denominator.
Assignee: nobody → bbouvier
Status: NEW → ASSIGNED
Attachment #8887581 -
Flags: review?(nicolas.b.pierron)
|
|
Assignee | |
Comment 2•7 years ago
|
||
Just code motion: - JitFrameIterator methods are moved from JitFrames.cpp to JitFrameIterator.cpp - some JitFrameIterator inline methods are moved from JitFrames-inl.h to JitFrameIterator-inl.h This passes make check-style and non-unified build on x64, let's see what try says: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b2aaf74414cfe0760a704cb1995a0b6cf6b5f7e
Attachment #8887582 -
Flags: review?(nicolas.b.pierron)
|
||
Updated•7 years ago
|
Attachment #8887581 -
Flags: review?(nicolas.b.pierron) → review+
|
|
||
Updated•7 years ago
|
Attachment #8887582 -
Flags: review?(nicolas.b.pierron) → review+
Pushed by bbouvier@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/33cf2dcc5aaf Use delegating ctors for JitFrameIterator; r=nbp https://hg.mozilla.org/integration/mozilla-inbound/rev/f15bf893f71f Move JitFrameIterator methods to their own cpp file; r=nbp
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/33cf2dcc5aaf https://hg.mozilla.org/mozilla-central/rev/f15bf893f71f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•