Closed
Bug 1382324
Opened 7 years ago
Closed 7 years ago
SpiderMonkey HashTable has poor hashing behavior for adjacent pointers
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
Details
Attachments
(1 file)
|
11.52 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
This is the SpiderMonkey version of bug 1379282 for https://searchfox.org/mozilla-central/rev/a83a4b68974aecaaacdf25145420e0fe97b7aa22/js/public/HashTable.h#588>.
|
Assignee | |
Comment 1•7 years ago
|
||
This is very similar to the fix to bug 1379282 for the XPCOM hashtables.
Attachment #8888013 -
Flags: review?(jdemooij)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8888013 [details] [diff] [review] Improve SpiderMonkey's pointer hashing function for pointers to neighboring memory locations Review of attachment 8888013 [details] [diff] [review]: ----------------------------------------------------------------- Nice, this is actually simpler than before. We should keep an eye on AWFY after this lands.
Attachment #8888013 -
Flags: review?(jdemooij) → review+
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c0e5f705407b Improve SpiderMonkey's pointer hashing function for pointers to neighboring memory locations; r=jandem
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c0e5f705407b
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•