1382326 - Remote or cache native look and feel metrics queries in content processes

Status: RESOLVED DUPLICATE of bug 1400317

(Core :: Widget: Win32, defect, P1)

Description

[Alex Gaynor [:Alex_Gaynor]]

Doing this goes through a win32k syscall. Here's what a stacktrace looks like:


2 - USER32!NtUserGetCaretBlinkTime
    USER32!NtUserGetCaretBlinkTime
    xul!nsLookAndFeel::GetIntImpl+0xb5
    xul!mozilla::LookAndFeel::GetInt+0xc
    xul!nsCaret::ResetBlinking+0x40
    xul!nsCaret::SetVisible+0x14
    xul!mozilla::PresShell::SetCaretEnabled+0x1f
    xul!nsTextInputSelectionImpl::SetCaretEnabled+0x8c
    xul!mozilla::EditorBase::InitializeSelection+0x14a
    xul!mozilla::EditorBase::OnFocus+0xe
    xul!mozilla::EditorEventListener::Focus+0x25a
    xul!mozilla::EditorEventListener::HandleEvent+0x95

Comment 1

[Jim Mathies [:jimm]]

accidentally marked this sec, please remove.

Comment 2

[Alex Gaynor [:Alex_Gaynor]]

Another stack that passes through nsLookAndFeel:

    win32u!NtUserSystemParametersInfo
    USER32!RealSystemParametersInfoW+0x82
    UxTheme!ClassicSystemParametersInfoW+0x29
    UxTheme!_InternalSystemParametersInfo+0x29
    UxTheme!ThemeSystemParametersInfoW+0xcb
    USER32!SystemParametersInfoW+0xa7
    UxTheme!IsHighContrastMode+0x2a
    UxTheme!IsThemeActive+0x5a
    UxTheme!IsAppThemed+0x16
    xul!nsLookAndFeel::GetIntImpl+0x40d
    xul!nsCSSRuleProcessor::InitSystemMetrics+0x2db
    xul!nsCSSRuleProcessor::HasSystemMetric+0xe
    xul!GetSystemMetric+0x52

Comment 3

[Jim Mathies [:jimm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d26ac65309fece765e8be822959646457d3e2156

Comment 4

[Jim Mathies [:jimm]]

Attachment: wip

Comment 5

[Gian-Carlo Pascutto [:gcp]]

This will be tackled as part of bug 1400317.