Closed Bug 1382556 Opened 7 years ago Closed 7 years ago

Verify that histogram_tools.py breaks compilation if "bug_numbers" is missing from new histograms

Categories

(Toolkit :: Telemetry, defect, P1)

Product:
Toolkit
Component:
Telemetry
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox54 --- unaffected
firefox55 --- wontfix
firefox56 --- fixed

People

(Reporter: Dexter, Assigned: Dexter)

References

Details

(Whiteboard: [measurement:client])

Attachments

(1 file)

bug1382556.patch
8.49 KB, patch
chutten
: review+
Details | Diff | Splinter Review 
That did not seem to happen in bug 1356812, when a new histogram was added with no bug_numbers field.
Assignee: nobody → alessio.placitelli
Priority: -- → P1
Whiteboard: [measurement:client]
Blocks: 1356812
Looks like that, even if the whitelist file is loaded, it is never used. This seems to be a regression from bug 1365577.
Blocks: 1365577
Attached patch bug1382556.patch — — Splinter Review 
Hey Chris, this patch marks the "whitelists" variable as global within |load_whitelists()|, otherwise the data won't be available from outside the function.

It also fixes the histogram that landed while this was broken.
Attachment #8888215 - Flags: review?(chutten)
Attachment #8888215 - Flags: review?(chutten) → review+
Pushed by alessio.placitelli@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ff87819abe8
Fix loading the whitelist file from histogram_tools.py. r=chutten
https://hg.mozilla.org/mozilla-central/rev/4ff87819abe8
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: