1382658 - Label dispatches from imgRequestProxy::Cancel

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, enhancement, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

imgRequestProxy::Cancel and imgRequestProxy::CancelAndForgetObserver call NS_DispatchToCurrentThread. These need to switch to our labelled event target (if available).

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: imgRequestProxy::DoRemoveFromLoadGroup and imgCancelRunnable should be dispatched on labelled group if possible., v1

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0df35b2897af85cc5db9a2fcc679b90e25d0d532

Comment 2

[Timothy Nikkel (:tnikkel)]

Comment on attachment 8888317 [details] [diff] [review]
imgRequestProxy::DoRemoveFromLoadGroup and imgCancelRunnable should be dispatched on labelled group if possible., v1

The name of the new function is kinda confusing, but I don't have a better idea.

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

Attachment: imgRequestProxy::DoRemoveFromLoadGroup and imgCancelRunnable should be dispatched on labelled group if possible., v2 [carries r=tnikkel]

I renamed Dispatch to DispatchWithTarget (will assert it has a target) and DispatchExpected to DispatchWithTargetIfAvailable (will use it if available, else use unlabelled).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/89f97a79f232
imgRequestProxy::DoRemoveFromLoadGroup and imgCancelRunnable should be dispatched on labelled group if possible. r=tnikkel

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/89f97a79f232