Closed Bug 1382720 Opened 7 years ago Closed 7 years ago

Refactor Zone::setGCState to assert previous state

Categories

(Core :: JavaScript: GC, enhancement)

Product:
Core
Component:
JavaScript: GC
Version:
55 Branch
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

bug1382720-change-zone-state
10.71 KB, patch
sfink
: review+
Details | Diff | Splinter Review 
Pretty much everywhere we call this we also assert the previous state.  It makes sense to do this as part of the method.

        Attachment #8888382 -
        Flags: review?(sphink)

        Attachment #8888382 -
        Flags: review?(sphink) → review+

    
    

    
  
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d9d10df4a135
Move zone state assertion into state update method r=sfink

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/d9d10df4a135
Status: NEW → RESOLVED
Closed: 7 years ago

          status-firefox56:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: