1382822 - onAuthRequired causes Firefox to crash while displaying address bar suggestions

Status: RESOLVED WORKSFORME

(WebExtensions :: Request Handling, defect)

Description

[Yehuda Katz]

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:54.0) Gecko/20100101 Firefox/54.0
Build ID: 20170628075643

Steps to reproduce:

I was trying to handle basic auth for proxy server set by proxy script.

browser.webRequest.onAuthRequired.addListener(function(details) {
  return {
    authCredentials: {username: 'user', password: 'pass'}
  };
}, {urls: ["<all_urls>"]}, ["blocking"]);


Actual results:

The authentication works fine for all URLs except for address bar hints. When I enable proxy in browser and start type domain name, suggestions are displayed and Firefox starts making request in background... I can see popup message asking for password (so it means it was not handled by listener) and if you enter anything or click OK button, Firefox crashes.


Expected results:

I even tried to clean up the listener with following:

browser.webRequest.onAuthRequired.addListener(function(details) {
  return {};
}, {urls: ["<all_urls>"]}, ["blocking"]);

but the same error happened. When I removed listener, I can see the same popup but Firefox does not crashes any more.

Comment 1

[Shane Caraveo (:mixedpuppy)]

I'm having a hard time reproducing this.  Is there any further details you can provide to reproduce?

Comment 2

[Yehuda Katz]

Hello Shane,

That was very couple of months ago =) Currently I have FF56 and I tested it again and seems like this problem was automatically resolved. I will reopen the case if I notice it again... the situation was like that:

Shane, the basic authentication was working fine. The pages where openning fine but when I was trying to type something in address bar, on the moment when hints should be displayed, there was fatal error and FF crashed.

With best regards

Yehuda

Comment 3

[Andy McKay]

Thanks Yehuda, marking as closed based on comment 2.