Closed Bug 1384749 Opened 7 years ago Closed 7 years ago

Make Sentry use a more random identifier for device_app_hash

Categories

(Firefox for iOS :: General, enhancement)

Product:
Firefox for iOS
Component:
General
Platform:
Other
iOS
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fxios 8.1+ ---

People

(Reporter: st3fan, Assigned: st3fan)

Details

(Whiteboard: [Sentry])

Attachments

(1 file)

PR https://github.com/mozilla-mobile/firefox-ios/pull/2983
55 bytes, text/x-github-pull-request
justindarc
: review+
Details | Review 
The default implementation of device_app_hash is a hash based on the IDFV plus additional properties of the device. We can change this to a (persisistent per install) random identifier that is not connected to iOS provided ID. This will then reset when the app is reinstalled.
Whiteboard: [Sentry]
Assignee: nobody → sarentz
This patch changes the default `device_app_hash` implementation with our own. The Sentry implementation is based on the *Identifier For Vendors* while our implementation is simply a completely random identifier that is reset on every install.
Status: NEW → ASSIGNED
Comment on attachment 8890863 [details] [review]
PR https://github.com/mozilla-mobile/firefox-ios/pull/2983

LGTM. See comment in PR about possibly using `NSUserDefaultsPrefs` instead.
Attachment #8890863 - Flags: review+
Landed on master, uplifted to v8.x
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: