Closed
Bug 1384818
Opened 7 years ago
Closed 7 years ago
Sync logs don't capture activity between the last sync and sync being reset.
Categories
(Firefox :: Sync, enhancement)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: markh, Assigned: markh)
Details
Attachments
(1 file)
If a user disconnects sync, the actions taken by the disconnection aren't logged anywhere. Worse, if we get a push notification about an account being deleted, that also isn't captured in logs. The fix to this is trivial, although it doesn't capture everything we care about due to sync not always having been initialized in time - but that's really bug 1380215.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8890683 [details] Bug 1384818 - flush sync log files on sync reset. https://reviewboard.mozilla.org/r/161866/#review167308 Thanks!
Attachment #8890683 -
Flags: review?(eoger) → review+
Pushed by mhammond@skippinet.com.au: https://hg.mozilla.org/integration/autoland/rev/face8d3f9fb9 flush sync log files on sync reset. r=eoger
Comment 4•7 years ago
|
||
Backed out for frequently failing xpcshell's services/sync/tests/unit/test_errorhandler_2.js on Linux: https://hg.mozilla.org/integration/autoland/rev/66c1061c0d08b3fff5bb0d4b47a268ab5b50f2be Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=face8d3f9fb9045e40b1eaabfa2794d6f4bae5ea&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=118741627&repo=autoland [task 2017-07-28T03:55:54.839315Z] 03:55:54 INFO - TEST-PASS | services/sync/tests/unit/test_errorhandler_2.js | test_sync_engine_generic_fail - [test_sync_engine_generic_fail : 849] "error.engine.reason.unknown_fail" == "error.engine.reason.unknown_fail" [task 2017-07-28T03:55:54.840470Z] 03:55:54 INFO - TEST-PASS | services/sync/tests/unit/test_errorhandler_2.js | test_sync_engine_generic_fail - [test_sync_engine_generic_fail : 850] "error.sync.failed_partial" == "error.sync.failed_partial" [task 2017-07-28T03:55:54.841526Z] 03:55:54 INFO - TEST-PASS | services/sync/tests/unit/test_errorhandler_2.js | test_sync_engine_generic_fail - [test_sync_engine_generic_fail : 854] true == true [task 2017-07-28T03:55:54.846277Z] 03:55:54 WARNING - TEST-UNEXPECTED-FAIL | services/sync/tests/unit/test_errorhandler_2.js | test_sync_engine_generic_fail - [test_sync_engine_generic_fail : 856] success-sync-1501214133449.txt - false == true [task 2017-07-28T03:55:54.847474Z] 03:55:54 INFO - /home/worker/workspace/build/tests/xpcshell/tests/services/sync/tests/unit/test_errorhandler_2.js:test_sync_engine_generic_fail:856 [task 2017-07-28T03:55:54.848323Z] 03:55:54 INFO - exiting test [task 2017-07-28T03:55:54.849193Z] 03:55:54 INFO - Unexpected exception 2147500036 [task 2017-07-28T03:55:54.850020Z] 03:55:54 INFO - undefined [task 2017-07-28T03:55:54.855158Z] 03:55:54 INFO - exiting test [task 2017-07-28T03:55:54.856246Z] 03:55:54 INFO - "CONSOLE_MESSAGE: (error) [JavaScript Error: "Sync encountered an error - see about:sync-log for the log file." {file: "resource://services-sync/policies.js" line: 772}] [task 2017-07-28T03:55:54.857158Z] 03:55:54 INFO - onComplete@resource://services-sync/policies.js:772:9 [task 2017-07-28T03:55:54.858092Z] 03:55:54 INFO - _do_main@/home/worker/workspace/build/tests/xpcshell/head.js:221:3 [task 2017-07-28T03:55:54.859011Z] 03:55:54 INFO - _execute_test@/home/worker/workspace/build/tests/xpcshell/head.js:544:5 [task 2017-07-28T03:55:54.864043Z] 03:55:54 INFO - @-e:1:1
Flags: needinfo?(markh)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•7 years ago
|
||
New try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=47c1469dbd9641199cd1071022eb5b132d0b5d39&selectedJob=119873400
Flags: needinfo?(markh)
Comment hidden (mozreview-request) |
Pushed by mhammond@skippinet.com.au: https://hg.mozilla.org/integration/autoland/rev/8ae7fae10cb2 flush sync log files on sync reset. r=eoger
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8ae7fae10cb2
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in
before you can comment on or make changes to this bug.
Description
•