1384856 - Mac: Tools Menu always shows "Sign In To Sync..." in BookMark Library window

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P2)

Description

[Will Wang [:WillWang]]

I feel confused: 
When I click the menu: "Bookmarks -> show all bookmarks", a new window is opened;
Then if I click menu: "Tools" of that new window, I will see "Sign In To Sync...", but I had already sign in.

I expect to see "Sync Now" as the original window shows.
Did I miss something?


OS: Mac OS X 10.12
Version: Nighlty 56.0a1 (20170726100322)

Not sure here is the right component to file, please help to move if needed :)

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Thanks for the report - I suspect this has been missed for a while since most other platforms don't have a menu for that window. We'll investigate.

Comment 2

[Lina Butler [:lina]]

Just a guess: could this be because we don't load `browser-sync.js` into `places.xul` when we open the organizer? (https://searchfox.org/mozilla-central/rev/dca019c94bf3a840ed7ff50261483410cfece24f/browser/base/content/browser-places.js#716-717, https://searchfox.org/mozilla-central/source/browser/components/places/content/places.xul)

Comment 4

[Thom Chiovoloni [:tcsc] (ex-moco)]

This also appears on the about dialog ("Firefox Nightly" > "About Nightly" for nightly users), and the page info dialog (Tools > Page Info).

The solution to each of these is probably to add gSync.init() to their initialization functions, but to be honest, I'm not sure this makes sense for the others...

Comment 5

[Mark Hammond [:markh] [:mhammond]]

(In reply to Thom Chiovoloni [:tcsc] from comment #4)
> This also appears on the about dialog ("Firefox Nightly" > "About Nightly"
> for nightly users), and the page info dialog (Tools > Page Info).

I think the right thing to do is work out the best way to remove/hide them in those windows.

Comment 6

[Thom Chiovoloni [:tcsc] (ex-moco)]

Attachment: Bug 1384856 - Fix sync menu items showing incorrect state on mac

Review commit: https://reviewboard.mozilla.org/r/213666/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213666/

Comment 7

[Edouard Oger [:eoger]]

Comment on attachment 8943331 [details]
Bug 1384856 - Fix sync menu items showing incorrect state on mac

https://reviewboard.mozilla.org/r/213666/#review219424

LGTM thanks!

Comment 8

[Thom Chiovoloni [:tcsc] (ex-moco)]

Comment on attachment 8943331 [details]
Bug 1384856 - Fix sync menu items showing incorrect state on mac

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/213666/diff/1-2/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c7a34d13dc3
Fix sync menu items showing incorrect state on mac r=eoger

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/0c7a34d13dc3