1385881 - Creating repeating event with UNTIL forgets the UNTIL part

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

STR:

1) create an (allday) daily repeating event using custom recurrence dialog, with 3 occurrences.
2) save and close
3) Open event again, edit all occurrences

Results:
* "Daily" is selected, no custom recurrence

Expected:
* "Custom" is selected with the three occurrences


Reported at 

https://www.thunderbird-mail.de/forum/thread/77013-neuer-termin-bearbeiten/?postID=422127#post422127

Comment 1

[Decathlon]

Attachment: patch-v1

I see a slightly different behavior: when reopening the event, it is still "Custom" but the string in the dialog shows no information about the number of occurrences. When you close the dialog it prompts to save before closing even without modification. If you save, then when reopening again, the event is "Daily" and recurs forever.

The issue comes from the patch for bug 566149.
The "count" part of the rule should not change when sorting out the until date.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8893280 [details] [diff] [review]
patch-v1

Review of attachment 8893280 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for looking into this so quickly! The patch looks fine, unfortunately I haven't found time to test if it also fixes my case. I'll retest this in the next nightly.

Comment 3

[Jorg K (CEST = GMT+2)]

Hmm, a review and uplift request without testing it. To save myself hassle I tested it with the test case described in comment #0. On a current Daily the fact that this only runs three times is lost when editing the event. With the patch, that information is maintained. Also, when I edit the even and don't make changes, I don't get the "event has not been saved" message. So as far as I can tell, this patch is a must-have ;-)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2e9acc97f408
Creating repeating event with UNTIL forgets the UNTIL part. r=philipp

Comment 5

[Jorg K (CEST = GMT+2)]

Beta (Calendar 5.8, TB 56):
https://hg.mozilla.org/releases/comm-beta/rev/712591caa82c35583fcfd6588454be200fc5c43c

P.S.: There is no target milestone 5.9 yet.

Comment 6

[Jorg K (CEST = GMT+2)]

ESR 52.3, Calendar 5.4.3:
https://hg.mozilla.org/releases/comm-esr52/rev/e2449611dd4c