Closed
Bug 138633
Opened 22 years ago
Closed 22 years ago
Esc key should close element properties dialog.
Categories
(SeaMonkey :: UI Design, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: martin, Assigned: stdowa+bugzilla)
References
Details
(Keywords: polish)
Attachments
(1 file)
860 bytes,
patch
|
jag+mozilla
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
It's just a little thing, but I think that things would be improved if the Esc key should close the element properties dialog. When I do web development, I frequently like to know the size of an image. It's great that you can right-click on it and get it's size, but I expect the dialog to go away if I press the escape key.
Comment 1•22 years ago
|
||
-> XP APPS
Assignee: Matti → blaker
Severity: minor → enhancement
Component: Browser-General → XP Apps: GUI Features
QA Contact: imajes-qa → paw
Comment 2•22 years ago
|
||
see similar bug 135945 Can't find a dupe, confirmed on Linux cvs today...
Severity: enhancement → minor
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: polish
OS: Windows 2000 → All
Assignee | ||
Comment 4•22 years ago
|
||
r=sicking, but get someone from the navigator team to sr this
Comment 7•22 years ago
|
||
Would it be better to turn this into a <dialog>? You'd get all the right dialog key functionality for free then.
*** Bug 186794 has been marked as a duplicate of this bug. ***
Comment 9•22 years ago
|
||
It's not going to be turned into a dialog. There was another bug report, long ago, that discussed that. It was agreed that it was an info window and not a dialog box. Does the patch still work?
Assignee | ||
Comment 10•22 years ago
|
||
Neil, yes.
Comment 11•22 years ago
|
||
Have you sent an email to the browser super reviewers yet? <http://www.mozilla.org/hacking/reviewers.html> mailto:alecf@netscape.com?cc=blaker@netscape.com&cc=jaggernaut@netscape.com&cc=reviewers@mozilla.org
Assignee | ||
Comment 12•22 years ago
|
||
Comment on attachment 83835 [details] [diff] [review] patch Neil, do you have a bug# for the discussion? jag/bz, can you r/sr?
Attachment #83835 -
Flags: superreview?(bzbarsky)
Attachment #83835 -
Flags: review?(jaggernaut)
Updated•22 years ago
|
Attachment #83835 -
Flags: superreview?(bzbarsky) → superreview+
Comment 13•22 years ago
|
||
I believe this is it: http://bugzilla.mozilla.org/show_bug.cgi?id=101910#c28
Comment 14•22 years ago
|
||
Comment on attachment 83835 [details] [diff] [review] patch r=jag
Attachment #83835 -
Flags: review?(jaggernaut) → review+
Assignee | ||
Comment 15•22 years ago
|
||
-> fixed.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Comment 16•22 years ago
|
||
Verified fixed in 2003011405/WinNT, /WinXP, /Win98se
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: Core → Mozilla Application Suite
You need to log in
before you can comment on or make changes to this bug.
Description
•