1386422 - Fix some error handling in StripHandlerFromOBJREF

Status: RESOLVED FIXED

(Core :: Disability Access APIs, enhancement)

Description

[(No longer employed by Mozilla) Aaron Klotz]

We should distinguish between "I have failed to read the OBJREF type" vs "this OBJREF type does not require us to make any changes"

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Patch

This patch ensures that we return true from StripHandlerFromOBJREF when the OBJREF does not supply a handler.

This patch also modifies the postcondition of StripHandlerFromOBJREF such that, whenever the function returns true, the stream is always positioned back to the end of the OBJREF.

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Patch (r2)

This patch ensures that we return true from StripHandlerFromOBJREF when the OBJREF does not include a handler (since there is nothing that it needs to do).

This patch also modifies the postcondition of StripHandlerFromOBJREF such that, whenever the function returns true, the stream is always positioned back to the end of the OBJREF.

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6d8f6382c8d0241712b735646a1d891bf83bb27d
Bug 1386422: Clean up error handling and stream positioning in StreamHandlerFromOBJREF; r=jimm

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/6d8f6382c8d0