1386587 - Comment and error message for pop3ServerBusy is wrong

Status: RESOLVED FIXED

(MailNews Core :: Networking: POP, defect)

Description

[Onno Ekker [:nONoNonO UTC+1]]

In chrome/mailnews/localMsgs.properties both for mail and suite the comment for pop3ServerBusy and the error message itself are both probably wrong. The comment seems to be wrongly copied and should read something like 'Status - pop3 server busy' or 'Status - pop3 folder busy' and the error message itself should possibly be tweaked, since it seems to occur when a local folder is busy and not when a server or an account is busy.

Comment 1

[Jorg K (CEST = GMT+2)]

# Status - write error occurred
# LOCALIZATION NOTE (pop3ServerBusy): Do not translate the word "%S" below.
# Place %S where the account name should appear.
pop3ServerBusy=The account %S is being processed. Please wait until processing is complete to get messages.

Well, it doesn't see so wrong to me. So most likely there was a write error on the folder, but we could use:
# Status - pop3 folder busy

What's your suggestion for the message?

CC'ing Richard who might help with a patch.

Comment 2

[Onno Ekker [:nONoNonO UTC+1]]

:frg suggested on IRC that the message might be wrong, maybe he has a suggestion for improving it?

Comment 3

[Frank-Rainer Grahl (:frg)]

> The account %S is being processed.

Maybe if this is not too long: "Server is currently busy. Operation for account %S in progress. Please wait until processing is complete to get messages." If it is indeed a folder busy message probably without the "Server is currently busy".

Acount being processed just doesn't feel right. 

fwiw I never saw the message yet.

Comment 4

[Onno Ekker [:nONoNonO UTC+1]]

If there's no suggestion to improve the entity, I propose to only fix the comment, as suggested by Jorg in comment #1.

Comment 5

[Jorg K (CEST = GMT+2)]

Attachment: 1386587-pop3ServerBusy.patch (v1)

Comment 6

[Onno Ekker [:nONoNonO UTC+1]]

Comment on attachment 8902208 [details] [diff] [review]
1386587-pop3ServerBusy.patch (v1)

Review of attachment 8902208 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not sure if I'm qualified to review, but this looks good to me :-)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9f258e1db839
Correct comment for pop3ServerBusy in localMsgs.properties. r=nONoNonO

Comment 8

[Jorg K (CEST = GMT+2)]

Thanks for the review. It's better to make sure the reporter is happy than land it without review and rs=comment-only. Besides, in cases like this I can choose my reviewer according to what I deem appropriate ;-)