Closed Bug 1386646 Opened 7 years ago Closed 7 years ago

Remove most GetJitContext calls

Categories

(Core :: JavaScript Engine: JIT, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
We'd like to remove GetJitContext at some point, because it encourages writing code that does a lot of TLS lookups and is slower than necessary.

Here's a patch to remove most of these calls. Removing all of them is a bit more work and not on my radar atm, but after this patch it should be easier to see what's left.
Attachment #8892917 - Flags: review?(luke)
Attachment #8892917 - Flags: review?(luke) → review+
I think this closes bug 1360624
See Also: → 1360624
(In reply to Ted Campbell [:tcampbell] from comment #1)
> I think this closes bug 1360624

Not entirely because there are still a number of them left, but I'll comment there.
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4346a6f167be
Remove most GetJitContext calls. r=luke
https://hg.mozilla.org/mozilla-central/rev/4346a6f167be
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: